public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 1/2] check-reqs.eclass: runtime disk checks for any path.
Date: Mon, 26 Feb 2024 09:46:59 +0000	[thread overview]
Message-ID: <robbat2-20240226T094217-858668474Z@orbis-terrarum.net> (raw)
In-Reply-To: <b713719c-12dd-4a65-a8a0-15d525ec8628@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Mon, Feb 26, 2024 at 08:01:28AM +0100, zzam@gentoo.org wrote:
> Am 26.02.24 um 07:31 schrieb Robin H. Johnson:
> > Allow checking any runtime path for installing ever-larger packages.
> > 
> > CHECKREQS_DISK_RUNTIME=( /boot:40M /:350M /opt:500M )
> 
> In the example case: Shouldn't the eclass check for 850M on / if /opt is 
> not a separate partition?
> I am not sure how often it really happens that multiple large 
> requirements for different folders exist.
I just summed up the 2 example packages here.

I do see your concern about the filesystem/mountpoint layout.

If it's a single /: that needs 850M
If it's split / and /opt: then it's the listed space in each location.

Correctly processing this would require converting each of the listed
check locations to their common mounts, summing the needs, and then
validating.

This should be possible with "stat --printf=%m" to resolve any directory
into it's mountpoint.

I'll see if it can be done trivially enough for the eclass.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation President & Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1113 bytes --]

  reply	other threads:[~2024-02-26  9:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 22:08 [gentoo-dev] [PATCH] check-reqs.eclass: more disk checks Robin H. Johnson
2024-02-19 22:14 ` [gentoo-dev] " Robin H. Johnson
2024-02-20  6:16   ` Michał Górny
2024-02-20  4:38 ` [gentoo-dev] " Sam James
2024-02-20  5:53 ` Andrew Ammerlaan
2024-02-26  6:31 ` [gentoo-dev] [PATCH v2 1/2] check-reqs.eclass: runtime disk checks for any path Robin H. Johnson
2024-02-26  7:01   ` zzam
2024-02-26  9:46     ` Robin H. Johnson [this message]
2024-02-26 13:50   ` Michał Górny
2024-02-26  6:31 ` [gentoo-dev] [PATCH v2 2/2] sys-firmware/intel-microcode: check-reqs for /boot space Robin H. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=robbat2-20240226T094217-858668474Z@orbis-terrarum.net \
    --to=robbat2@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox