public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 1/4] kernel-install.eclass: Install logic for dist-kernels
Date: Sun, 5 Jan 2020 07:30:49 +0000	[thread overview]
Message-ID: <robbat2-20200105T072322-014212601Z@orbis-terrarum.net> (raw)
In-Reply-To: <20200105062741.82357-1-mgorny@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On Sun, Jan 05, 2020 at 07:27:38AM +0100, Michał Górny wrote:
> Introduce a new eclass that contains common logic needed to test
> and install distribution kernels.  This is the eclass common both
> to kernels built from source and installed from binary packages.
I'm 100% in favour of the concept here, but I have some implementation
concerns.

For the (public) record, Infra has been wrapping genkernel to build
binary kernel + initramfs for internal usage for 5 years now.

Conceptually, can you clarify why you are depending on dracut here,
rather than using genkernel's initramfs mode?

I'm not sure you're going to get correct build output in cases like
x86_64 -> x86 cross-compiles.

Why not call genkernel from the ebuild instead of re-inventing the
wheel to compile the kernel yourself.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1113 bytes --]

  parent reply	other threads:[~2020-01-07  2:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-05  6:27 [gentoo-dev] [PATCH v2 1/4] kernel-install.eclass: Install logic for dist-kernels Michał Górny
2020-01-05  6:27 ` [gentoo-dev] [PATCH v2 2/4] kernel-build.eclass: Build " Michał Górny
2020-01-06 17:43   ` Mike Gilbert
2020-01-06 17:54     ` Michał Górny
2020-01-06 18:07       ` Mike Gilbert
2020-01-06 18:13         ` Michał Górny
2020-01-05  6:27 ` [gentoo-dev] [PATCH v2 3/4] sys-kernel/vanilla-kernel: Migrate to kernel-build.eclass Michał Górny
2020-01-05  6:27 ` [gentoo-dev] [PATCH v2 4/4] sys-kernel/vanilla-kernel-bin: Migrate to kernel-install.eclass Michał Górny
2020-01-05  7:30 ` Robin H. Johnson [this message]
2020-01-07  6:11   ` [gentoo-dev] [PATCH v2 1/4] kernel-install.eclass: Install logic for dist-kernels Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=robbat2-20200105T072322-014212601Z@orbis-terrarum.net \
    --to=robbat2@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox