[gentoo-dev] about commits in the future

[gentoo-dev] about commits in the future

[Fabian Groffen]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Please consider commit 2fb923d758749be609c1daab2a72ad4f1ec4c2a9
(use something like
   git log --pretty=fuller app-emulation/nemu/nemu-1.4.0.ebuild)

It was made roughly one day in the future.  I'm wondering:
1) is this bad at all?
2) if it is bad (got me confused for another reason) is it technically
   possible to reject such commits?
3) if 2) should we decide on some clock skew and reject anything which
   is beyond that?

How do others feel about this?

Thanks,
Fabian

-- 
Fabian Groffen
Gentoo on a different level

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] about commits in the future

[Patrice Clement]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi Fabian

Every now and then, my commits get rejected from the Gentoo Git server with an
error saying that my clock is behind and that I need to rewind it. I then run
the command `ntpdate europe.pool.ntp.org' to get my clock synced. Eventually, I
rebase my latest commits with git and push to the repo. Something might have
gone wrong during the clock sync and git rebase? I'm not too sure.

Thanks for pointing out this oddity though!

Wednesday 21 Feb 2018 09:47:29, Fabian Groffen wrote :
> Please consider commit 2fb923d758749be609c1daab2a72ad4f1ec4c2a9
> (use something like
>    git log --pretty=fuller app-emulation/nemu/nemu-1.4.0.ebuild)
> 
> It was made roughly one day in the future.  I'm wondering:
> 1) is this bad at all?
> 2) if it is bad (got me confused for another reason) is it technically
>    possible to reject such commits?
> 3) if 2) should we decide on some clock skew and reject anything which
>    is beyond that?
> 
> How do others feel about this?
> 
> Thanks,
> Fabian
> 
> -- 
> Fabian Groffen
> Gentoo on a different level

-- 
Patrice Clement
Gentoo Linux developer
http://www.gentoo.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: [gentoo-dev] about commits in the future

[James Le Cuirot]

On Wed, 21 Feb 2018 09:59:49 +0100
Patrice Clement <monsieurp@gentoo.org> wrote:

> Every now and then, my commits get rejected from the Gentoo Git
> server with an error saying that my clock is behind and that I need
> to rewind it. I then run the command `ntpdate europe.pool.ntp.org' to
> get my clock synced. Eventually, I rebase my latest commits with git
> and push to the repo. Something might have gone wrong during the
> clock sync and git rebase? I'm not too sure.

A git rebase does not change the authored date unless you pass
--ignore-date.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

Re: [gentoo-dev] about commits in the future

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On Wed, Feb 21, 2018 at 09:47:29AM +0100, Fabian Groffen wrote:
> Please consider commit 2fb923d758749be609c1daab2a72ad4f1ec4c2a9
> (use something like
>    git log --pretty=fuller app-emulation/nemu/nemu-1.4.0.ebuild)
> 
> It was made roughly one day in the future.  I'm wondering:
> 1) is this bad at all?
that's a very subjective question.

> 2) if it is bad (got me confused for another reason) is it technically
>    possible to reject such commits?
> 3) if 2) should we decide on some clock skew and reject anything which
>    is beyond that?
I thought the existing hook SHOULD have rejected this, but I'm going to
go back and review that.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 1113 bytes --]