From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 420FC1396D9 for ; Mon, 6 Nov 2017 20:43:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B81C6E0E0F; Mon, 6 Nov 2017 20:42:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5E603E0D12 for ; Mon, 6 Nov 2017 20:42:56 +0000 (UTC) Received: from grubbs.orbis-terrarum.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 418E534169D for ; Mon, 6 Nov 2017 20:42:55 +0000 (UTC) Received: (qmail 14790 invoked by uid 10000); 6 Nov 2017 20:42:53 -0000 Date: Mon, 6 Nov 2017 20:42:53 +0000 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [v1.0.3] GLEP 74: Full-tree verification using Manifest files Message-ID: References: <1509048745.18656.6.camel@gentoo.org> <1509649919.21210.12.camel@gentoo.org> <1509916232.21193.19.camel@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KimiHFv5Iq53dGjv" Content-Disposition: inline In-Reply-To: <1509916232.21193.19.camel@gentoo.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-Archives-Salt: 08aa017b-a6bd-45c5-b33d-e71d89db6d2a X-Archives-Hash: 95e9905267eba75442d284e5fa5012e4 --KimiHFv5Iq53dGjv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 05, 2017 at 10:10:32PM +0100, Micha=C5=82 G=C3=B3rny wrote: > > Nits:=20 > > - please stick to ASCII ellipsis. The unicode ellipsis is unreadable in > > some monospace fonts. > Done. Also replaced '=E2=80=94' for consistency. I wasn't even aware you had used a different dash, it was rendered identically here, definitely thanks for fixing that too. > > Further items inline: > > > Directory tree coverage > > > ----------------------- > I've went for something even more explicit: > | If files or directories that are not otherwise ignored reside > | on a different filesystem, or symbolic links point to targets > | on a different filesystem, they must be explicitly excluded > | via ``IGNORE``. +1, resolves the concern very well, nice and clear. > > > Tree layout restrictions > > > ------------------------ > > 'common' in the second sentence seems odd. What about uncommon > > filenames? Maybe just s/other common filenames/other filenames/. > Done. The idea was to say 'do not put IGNORE for corner cases which are > better handled via PM config' but I guess it's not necessary here. Yes. Generally, IGNORE entries in Manifest should be for files distributed alongside the Manifest. We're say as common special cases, that local/distfiles/packages/lost+found are also known for ignore, since they have previously-defined meaning in the repo (along with the old timestamp files). > > > Non-strict Manifest verification > > > -------------------------------- > Rewritten to: > | It is much more common for users to strip whole packages > | or categories. The ``MISC`` type is not suitable for that, > | and so a dedicated package manager mechanism needs to be developed > | instead; possibly combining it with rsync exclusion list. The same > | mechanism can also handle files that historically used the ``MISC`` > | type. > But it's merely a rationale, so I'd rather not spend another hour trying > to cover every corner case in it. +1. Maybe cover it with a single sentence, "As an example, the package manager may choose to generate both the rsync exclusion list and Manifest IGNORE based on a source list" --=20 Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Asst. Treasurer E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 --KimiHFv5Iq53dGjv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Robbat2 @ Orbis-Terrarum Networks - The text below is a digital signature. If it doesn't make any sense to you, ignore it. iQKTBAEBCgB9FiEEveu2pS8Vb98xaNkRGTlfI8WIJsQFAloAyUxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJE RUJCNkE1MkYxNTZGREYzMTY4RDkxMTE5Mzk1RjIzQzU4ODI2QzQACgkQGTlfI8WI JsQOcw/+NpF13gQPdSLy2N2t4bBI60CEvlaDS33R3cl59PT3X3j6eMrGap0PFBSt NMR0W17mMIusTuy3lh4MKHgi1p0YndBEcSaTN3H/6nwlLCTDjs58VFRbgZmOWrPV Xbm87KL/AZHlkxKL2UczBkbKbjuC/y4oGd7i1Lb0+qxHjy0nAIXe0o4IWgyhPVFd z8sfupkC4iW4tav5iynsFxJyYZ2636QV6d8iVGKHxQbevBdHUJ+xvhXRsqg/01ej lKLH/2FqN1QCWUBMMF3GmyxOvzwtls1wu+9qJN6GslB6wS6dUpGxwwMxWQKo/YGo HwJp+P/G/ZQEOmcCirHbFyaBKKEAvCeufy1dZnzR0VJFWw55+GGWiM2TBGt3iip5 5h3xjqiuRGPXtlYLWIIXaxv2lhcI6qncG4/PmDJHH+/B+rgFwu1vTR87qX94yMSm Qpb3sKPPlzEg3JAXTDaBfbe58lzO1YWAP8+lJ2wPiqyE4dLnmqVyZo44tg2Mr1GF caTtbCiT/WxylWjhAsToYiqbd1q9e+kQ05dhaa7mgonJh3UV/YjjTsvgYrYLpmcl DSHcsBBDEMSnNZgUq3m2UEfgwH7ArObY8vkKot5H6jZ5ceqKIsFPbhXhKHvF4Rwf q5lgLdcf2oqIh/wHT5h8TWpY5fT84QGdvsaVYcyAhFaoaEVMUCA= =nmj7 -----END PGP SIGNATURE----- --KimiHFv5Iq53dGjv--