[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[Robin H. Johnson]

 * ERROR: net-wireless/gr-air-modes-9999::gentoo failed (depend phase):
  *   PYTHON_COMPAT not declared.

On Mon, Feb 20, 2017 at 05:43:10PM +0000, Michał Górny wrote:
> commit:     5458c6d9da6bbb3b4009a4ff9d9ab17737d07849
> Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
> AuthorDate: Mon Feb 20 16:43:24 2017 +0000
> Commit:     Michał Górny <mgorny <AT> gentoo <DOT> org>
> CommitDate: Mon Feb 20 17:43:03 2017 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5458c6d9
> 
> net-wireless/gr-air-modes: python-single-r1
> 
>  net-wireless/gr-air-modes/gr-air-modes-9999.ebuild | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild b/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
> index 130d60dfad..6b9482d54e 100644
> --- a/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
> +++ b/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
> @@ -1,9 +1,9 @@
> -# Copyright 1999-2016 Gentoo Foundation
> +# Copyright 1999-2017 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  # $Header: $
>  
>  EAPI=5
> -inherit python cmake-utils git-2
> +inherit python-single-r1 cmake-utils git-2
>  
>  DESCRIPTION="This module implements a complete Mode S and ADS-B receiver for Gnuradio"
>  HOMEPAGE="https://www.cgran.org/wiki/gr-air-modes"
> @@ -18,18 +18,16 @@ SLOT="0"
>  IUSE="rtlsdr fgfs +gui uhd"
>  DEPEND=">=net-wireless/gnuradio-3.7.0:=
>  	net-wireless/gr-osmosdr
> -	dev-python/pyzmq
> +	dev-python/pyzmq[${PYTHON_USEDEP}]
>  	fgfs? ( sci-libs/scipy
>  		games-simulation/flightgear )
>  	rtlsdr? ( net-wireless/rtl-sdr )
>  	uhd? ( >=net-wireless/uhd-3.4.0 )
> -	gui? ( dev-python/pyqwt )"
> +	gui? ( dev-python/pyqwt[${PYTHON_USEDEP}] )
> +	${PYTHON_DEPS}"
>  RDEPEND="${DEPEND}"
>  
> -pkg_setup() {
> -	python_set_active_version 2
> -	python_pkg_setup
> -}
> +REQUIRED_USE="${PYTHON_REQUIRED_USE}"
>  
>  src_compile() {
>  	cmake-utils_src_compile -j1
> @@ -37,5 +35,5 @@ src_compile() {
>  
>  src_install() {
>  	cmake-utils_src_install
> -	python_convert_shebangs 2 "${ED}"usr/bin/*
> +	python_fix_shebang "${ED}"usr/bin
>  }
> 

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[M. J. Everitt]

[-- Attachment #1.1: Type: text/plain, Size: 2420 bytes --]

On 20/02/17 18:09, Robin H. Johnson wrote:
>  * ERROR: net-wireless/gr-air-modes-9999::gentoo failed (depend phase):
>   *   PYTHON_COMPAT not declared.
>
> On Mon, Feb 20, 2017 at 05:43:10PM +0000, Michał Górny wrote:
>> commit:     5458c6d9da6bbb3b4009a4ff9d9ab17737d07849
>> Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
>> AuthorDate: Mon Feb 20 16:43:24 2017 +0000
>> Commit:     Michał Górny <mgorny <AT> gentoo <DOT> org>
>> CommitDate: Mon Feb 20 17:43:03 2017 +0000
>> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5458c6d9
>>
>> net-wireless/gr-air-modes: python-single-r1
>>
>>  net-wireless/gr-air-modes/gr-air-modes-9999.ebuild | 16 +++++++---------
>>  1 file changed, 7 insertions(+), 9 deletions(-)
>>
>> diff --git a/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild b/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
>> index 130d60dfad..6b9482d54e 100644
>> --- a/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
>> +++ b/net-wireless/gr-air-modes/gr-air-modes-9999.ebuild
>> @@ -1,9 +1,9 @@
>> -# Copyright 1999-2016 Gentoo Foundation
>> +# Copyright 1999-2017 Gentoo Foundation
>>  # Distributed under the terms of the GNU General Public License v2
>>  # $Header: $
>>  
>>  EAPI=5
>> -inherit python cmake-utils git-2
>> +inherit python-single-r1 cmake-utils git-2
>>  
>>  DESCRIPTION="This module implements a complete Mode S and ADS-B receiver for Gnuradio"
>>  HOMEPAGE="https://www.cgran.org/wiki/gr-air-modes"
>> @@ -18,18 +18,16 @@ SLOT="0"
>>  IUSE="rtlsdr fgfs +gui uhd"
>>  DEPEND=">=net-wireless/gnuradio-3.7.0:=
>>  	net-wireless/gr-osmosdr
>> -	dev-python/pyzmq
>> +	dev-python/pyzmq[${PYTHON_USEDEP}]
>>  	fgfs? ( sci-libs/scipy
>>  		games-simulation/flightgear )
>>  	rtlsdr? ( net-wireless/rtl-sdr )
>>  	uhd? ( >=net-wireless/uhd-3.4.0 )
>> -	gui? ( dev-python/pyqwt )"
>> +	gui? ( dev-python/pyqwt[${PYTHON_USEDEP}] )
>> +	${PYTHON_DEPS}"
>>  RDEPEND="${DEPEND}"
>>  
>> -pkg_setup() {
>> -	python_set_active_version 2
>> -	python_pkg_setup
>> -}
>> +REQUIRED_USE="${PYTHON_REQUIRED_USE}"
>>  
>>  src_compile() {
>>  	cmake-utils_src_compile -j1
>> @@ -37,5 +35,5 @@ src_compile() {
>>  
>>  src_install() {
>>  	cmake-utils_src_install
>> -	python_convert_shebangs 2 "${ED}"usr/bin/*
>> +	python_fix_shebang "${ED}"usr/bin
>>  }
>>
Nice .. esp. coming from a QA dev ...


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[Matthias Maier]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]


> Nice .. esp. coming from a QA dev ...

This is an absolutely inappropriate response.

Especially from a Mentee and prospective new Developer.

Matthias

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[Kent Fredric]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

On Mon, 20 Feb 2017 18:27:22 +0000
"M. J. Everitt" <m.j.everitt@iee.org> wrote:

> Nice .. esp. coming from a QA dev ...

It makes sense though how it could happen, given:

- Its a -9999 package
- 9999 packages are typically keyworded as ""
- repoman pretty much ignores they're even there

Also, given its a -9999 package, standards and assumptions of quality are
typically much lower.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[Alexis Ballier]

On Tue, 21 Feb 2017 13:16:59 +1300
Kent Fredric <kentnl@gentoo.org> wrote:

> Also, given its a -9999 package, standards and assumptions of quality
> are typically much lower.

not at all; a lot of people do maintain -9999 pretty well in order to
follow upstream and use it as a template when bumping the next version,
so standards and assumptions of quality are actually higher there :)

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-wireless/gr-air-modes/

[Francesco Riosa]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

2017-02-21 12:56 GMT+01:00 Alexis Ballier <aballier@gentoo.org>:

> On Tue, 21 Feb 2017 13:16:59 +1300
> Kent Fredric <kentnl@gentoo.org> wrote:
>
> > Also, given its a -9999 package, standards and assumptions of quality
> > are typically much lower.
>
> not at all; a lot of people do maintain -9999 pretty well in order to
> follow upstream and use it as a template when bumping the next version,
> so standards and assumptions of quality are actually higher there :)
>
> yes, or to look from a different angle, speaking for -9999 packages _in_
tree:
It can be expected that it does not build because the ebuild has not caught
up with upstream, hopefully for the shortest time possible.
_but_ it should have the same level of (bash/EAPI/deps) code cleanliness of
any other ebuild.

BTW that help a lot we, users, that want to test that package in the limbo
time upstream has done some changes and the ebuild as not caught up.
Othrewise just avoid the -9999 in tree, a lot of developer have said they
are evil in the past (right?)

cheers,
Francesco

[-- Attachment #2: Type: text/html, Size: 1466 bytes --]

Live ebuilds in the main tree (was: Re: [gentoo-dev] ...)

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Am Dienstag, 21. Februar 2017, 14:39:55 CET schrieb Francesco Riosa:

> BTW that help a lot we, users, that want to test that package in the limbo
> time upstream has done some changes and the ebuild as not caught up.
> Othrewise just avoid the -9999 in tree, a lot of developer have said they
> are evil in the past (right?)

Actually I'm not so convinced that -9999 live ebuilds in the tree are "evil" 
anymore (assuming they have no keywords). 

Why?

Compare the git history of, say, app-office/libreoffice (with the live ebuilds in 
the main tree), with kde-apps/kmail (with the live ebuilds separately in the 
kde overlay).

For LibreOffice one can easily follow not just the version bumps but also the 
changes to the live ebuilds, which often document why something was changed 
(bug number, upstream modification).

For KMail the main tree mainly has "Added version" and "Removed version" 
commits, but if and why the ebuilds changed between versions is essentially 
documented in the kde overlay.


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer (council, perl, libreoffice)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: Live ebuilds in the main tree (was: Re: [gentoo-dev] ...)

[Alexis Ballier]

On Tue, 21 Feb 2017 22:58:03 +0100
"Andreas K. Huettel" <dilfridge@gentoo.org> wrote:

> Am Dienstag, 21. Februar 2017, 14:39:55 CET schrieb Francesco Riosa:
> 
> > BTW that help a lot we, users, that want to test that package in
> > the limbo time upstream has done some changes and the ebuild as not
> > caught up. Othrewise just avoid the -9999 in tree, a lot of
> > developer have said they are evil in the past (right?)  
> 
> Actually I'm not so convinced that -9999 live ebuilds in the tree are
> "evil" anymore (assuming they have no keywords). 
> 
> Why?
> 
> Compare the git history of, say, app-office/libreoffice (with the
> live ebuilds in the main tree), with kde-apps/kmail (with the live
> ebuilds separately in the kde overlay).


Yeah there is that, and it is also much simpler to maintain a live
ebuild than to rewrite and check 10 new configure options at each major
version.
This assumes the maintainer is using the live ebuild quite seriously
though :)