From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3F5D21384B4 for ; Mon, 7 Dec 2015 19:36:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6250121C071; Mon, 7 Dec 2015 19:36:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5E2B621C05F for ; Mon, 7 Dec 2015 19:36:18 +0000 (UTC) Received: from grubbs.orbis-terrarum.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 573A63407D0 for ; Mon, 7 Dec 2015 19:36:17 +0000 (UTC) Received: (qmail 17053 invoked by uid 10000); 7 Dec 2015 19:36:17 -0000 Date: Mon, 7 Dec 2015 19:36:17 +0000 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] git update hook: detecting missing Manifest DIST entries Message-ID: References: <1449465322.37c1ec7ef31a51206421f03a2df489ec7d7ca244.cardoe@gentoo> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5/uDoXvLw7AC5HRs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Archives-Salt: bb275c2a-5615-4774-b129-60275d31bb49 X-Archives-Hash: 96b074df80ff5f0e9aad864c786b87b4 --5/uDoXvLw7AC5HRs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 07, 2015 at 11:20:48AM -0800, Matt Turner wrote: > >> This is happening with some frequency. Could we install a server-side > >> git hook that prevents pushes if an ebuild is added without a Manifest > >> change? It wouldn't have to verify anything more than that to catch > >> nearly all of these problems. > > That would not work for ebuilds which do not have any distfiles > > associated with them. >=20 > Good point. >=20 > It *would* have to be somewhat more involved then... I have given a lot of thought to it as well, because I've fixed it a couple of times already or poked people to, and here's the best we can do for the moment: 1. Script #1 (helper), that given an ebuild, spits out the filenames of the distfiles.=20 - Use an explicitly specified PORTDIR for eclasses. - Must NOT rely on the ebuild directory structure (i'd love to give it the ebuild via stdin and tell it the path). 2. Script #2 (git update hook), check that filenames of distfiles are in the Manifest 3. Abort if #2 fails. Potential problems: It'll have to rely on a potentially less up to date set of eclasses. So if there is an eclass change shortly followed by an ebuild change, and the eclass change influences the distfiles, it MIGHT get it wrong (in either direction). I have existing code similar to script #2, so we just need script #1. --=20 Robin Hugh Johnson Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 --5/uDoXvLw7AC5HRs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1 Comment: Robbat2 @ Orbis-Terrarum Networks - The text below is a digital signature. If it doesn't make any sense to you, ignore it. iKYEARECAGYFAlZl37BfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1OTQwNEJFQkQ0MUY3MTIzODIzODZFRjNF OTIyQzIyMzIzM0MyMkMACgkQPpIsIjIzwixj8gCfRC3m1cJ+JG2Qh483eUsAFHcP b8wAoKqVypCWYQMH6CFBP03fuoxRA3QK =aDsm -----END PGP SIGNATURE----- --5/uDoXvLw7AC5HRs--