[gentoo-dev] git update hook: detecting missing Manifest DIST entries

["Robin H. Johnson" <robbat2@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On Mon, Dec 07, 2015 at 11:20:48AM -0800, Matt Turner wrote:
> >> This is happening with some frequency. Could we install a server-side
> >> git hook that prevents pushes if an ebuild is added without a Manifest
> >> change? It wouldn't have to verify anything more than that to catch
> >> nearly all of these problems.
> > That would not work for ebuilds which do not have any distfiles
> > associated with them.
> 
> Good point.
> 
> It *would* have to be somewhat more involved then...
I have given a lot of thought to it as well, because I've fixed it a
couple of times already or poked people to, and here's the best we can
do for the moment:

1. Script #1 (helper), that given an ebuild, spits out the filenames of the
   distfiles. 
   - Use an explicitly specified PORTDIR for eclasses.
   - Must NOT rely on the ebuild directory structure (i'd love to give
	 it the ebuild via stdin and tell it the path).
2. Script #2 (git update hook), check that filenames of distfiles are in
   the Manifest
3. Abort if #2 fails.

Potential problems:
It'll have to rely on a potentially less up to date set of eclasses.
So if there is an eclass change shortly followed by an ebuild change,
and the eclass change influences the distfiles, it MIGHT get it wrong
(in either direction).

I have existing code similar to script #2, so we just need script #1.

-- 
Robin Hugh Johnson
Gentoo Linux: Developer, Infrastructure Lead, Foundation Trustee
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 445 bytes --]