From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A8D551381F3 for ; Sat, 22 Jun 2013 00:26:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 380F2E0A91; Sat, 22 Jun 2013 00:26:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3FD06E0A89 for ; Sat, 22 Jun 2013 00:26:05 +0000 (UTC) Received: from grubbs.orbis-terrarum.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4300633E679 for ; Sat, 22 Jun 2013 00:26:04 +0000 (UTC) Received: (qmail 29412 invoked by uid 10000); 22 Jun 2013 00:26:03 -0000 Date: Sat, 22 Jun 2013 00:26:03 +0000 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Soliciting input for a non-maintainer update (NMU) GLEP Message-ID: References: <201306211940.03851.vapier@gentoo.org> <201306212017.38571.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201306212017.38571.vapier@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Archives-Salt: cbb88e84-131d-48ca-aa95-d21f314711dd X-Archives-Hash: 57cea61f9cf7e7561722ff7c08fa01e6 On Fri, Jun 21, 2013 at 08:17:38PM -0400, Mike Frysinger wrote: > > I'm not going into review systems here at all, I'm simply trying to have > > a policy of what changes are welcomed/blocked WITHOUT interaction from > > the listed maintainer(s) of a given package/herd. > add a new field to metadata.xml that declares the state. make it an enum: > ANYTHING_GOES (the default) > REQUIRES_HERD > REQUIRES_MAINTAINER I wish it was that easy. Despite being ANYTHING_GOES on most of my packages, I don't want people to add giant features like qmail patchbombs; so we need to figure out something like the Debian NMU listing of what's acceptable. Does this need to be coded in the metadata? Does a version bump count as an acceptable trivial change? > > If they have to ask me to review a trivial patch, I've already failed > > them. I don't want ANY gatekeeping, I want them to go and commit it > > already. > > > > Then extending THAT to Gerrit, who is responsible/allowed to hit that > > web interface submit button? > have gerrit check metadata.xml and see if the policy declared in there lines > up with the gerrit approvals attained. blam, done. That's why we need the policies on who/what first. -- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85