From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 1BD9213877A for ; Sun, 22 Jun 2014 13:02:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D02B0E095A; Sun, 22 Jun 2014 13:02:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EC070E093D for ; Sun, 22 Jun 2014 13:02:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 4BD3D340042 for ; Sun, 22 Jun 2014 13:02:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV at gentoo.org X-Spam-Flag: NO X-Spam-Score: -1.172 X-Spam-Level: X-Spam-Status: No, score=-1.172 tagged_above=-999 required=5.5 tests=[AWL=-1.160, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no Received: from smtp.gentoo.org ([IPv6:::ffff:127.0.0.1]) by localhost (smtp.gentoo.org [IPv6:::ffff:127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yYRtfhiTXEyA for ; Sun, 22 Jun 2014 13:02:20 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 48F7E33FEDC for ; Sun, 22 Jun 2014 13:02:19 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WyhPU-0000Bu-3K for gentoo-dev@gentoo.org; Sun, 22 Jun 2014 15:02:16 +0200 Received: from ip68-231-22-224.ph.ph.cox.net ([68.231.22.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 22 Jun 2014 15:02:16 +0200 Received: from 1i5t5.duncan by ip68-231-22-224.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 22 Jun 2014 15:02:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-dev] Re: perl-module.eclass: respect CFLAGS, LDFLAGS - please review Date: Sun, 22 Jun 2014 13:02:01 +0000 (UTC) Message-ID: References: <201406221141.08772.dilfridge@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip68-231-22-224.ph.ph.cox.net User-Agent: Pan/0.140 (Chocolate Salty Balls; GIT d447f7c /m/p/portage/src/egit-src/pan2) X-Archives-Salt: 80dea681-e896-436c-abf9-acf2ec931559 X-Archives-Hash: dbdb7425a0393c26570855315af46024 Andreas K. Huettel posted on Sun, 22 Jun 2014 11:41:01 +0200 as excerpted: > Also people familiar with Perl have voiced doubts if we should meddle > with the perl-module CFLAGS and LDFLAGS at all, maybe making these > changes conditional on something like I_KNOW_WHAT_I_AM_DOING. Hoping for > comments. The usual conditional for that is USE=custom-cflags or a similar variant like custom-optimization. See the firefox ebuilds, which use both. $ equery -N u firefox | grep custom - - custom-cflags : Build with user-specified CFLAGS (unsupported) + + custom-optimization : Fine-tune custom compiler optimizations (-Os, -O0, -O1, -O2, -O3) Generally, such USE flags are discouraged in gentoo, where honoring a user's CFLAGS, etc. and letting them keep the pieces if it comes to that is the norm. Where upstream refuses to support custom cflags, however, the USE flag solution seems to be an accepted at maintainer discretion. (FWIW I have USE=custom-cflags set globally, but package.use-disabled it for firefox when firefox-28 or so decided it didn't like the ones I was using. At some point I'll probably go back and figure out which one it is and filter it specifically, but unsetting that USE flag was both a useful first-step debug and a reasonable quick fix for the time being.) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman