From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id A402A138283 for ; Fri, 27 May 2016 02:48:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1EA38142BC; Fri, 27 May 2016 02:48:19 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2BF24142B4 for ; Fri, 27 May 2016 02:48:17 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b67ot-0003Gw-2k for gentoo-dev@lists.gentoo.org; Fri, 27 May 2016 04:48:15 +0200 Received: from ip98-167-165-199.ph.ph.cox.net ([98.167.165.199]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 04:48:15 +0200 Received: from 1i5t5.duncan by ip98-167-165-199.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 27 May 2016 04:48:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-dev] Re: [PATCH] git-r3.eclass: Support checking out repo by date, #510704 Date: Fri, 27 May 2016 02:48:07 +0000 (UTC) Message-ID: References: <20160526120826.24389-1-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip98-167-165-199.ph.ph.cox.net User-Agent: Pan/0.141 (Tarzan's Death; GIT 5ca29ba90) X-Archives-Salt: dbecf2b8-529e-4962-aa05-9084c59a3a31 X-Archives-Hash: ece25e8941e4893d983415b14cac237c Michał Górny posted on Thu, 26 May 2016 14:08:26 +0200 as excerpted: > @@ -254,6 +269,15 @@ _git-r3_env_setup() { > [[ ${!livevar} ]] \ > && ewarn "Using ${livevar}, no support will be provided" > > + livevar=${esc_pn}_LIVE_COMMIT_DATE > + EGIT_COMMIT_DATE=${!livevar-${EGIT_COMMIT_DATE}} > + [[ ${!livevar} ]] \ > + && ewarn "Using ${livevar}, no support will be provided" I'd guess that for consistency you want this to be the... if [[...]]; then ... style that seems to be preferred in this eclass, instead of the bare... [[...]] && ... style used here. (Tho I personally actually prefer the bare [[...]] && style if there's no else clause, if/then/else to make it explicit if there is. But that's not what the existing code seems to use, so...) Meanwhile, in general, I love the idea of having commit date access, of course with a user override available. I only have a lite kde/plasma install, but it's all live-9999 packages from the kde overlay and of course they're all git now, in addition to the pan-9999 ebuild in my overlay as I'm involved upstream there, so I make a *lot* of use of git-r3 eclass, and having date override available will definitely help with the occasional troubleshooting or easy revert to a date I know actually worked! =:^) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman