[gentoo-dev] [PATCH] flag-o-matic.eclass: add append-time64-flags

[gentoo-dev] [PATCH] flag-o-matic.eclass: add append-time64-flags

[Sam James]

Signed-off-by: Sam James <sam@gentoo.org>
---
 eclass/flag-o-matic.eclass | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index 365741a6dddf..d9149ebee4a5 100644
--- a/eclass/flag-o-matic.eclass
+++ b/eclass/flag-o-matic.eclass
@@ -301,6 +301,19 @@ append-lfs-flags() {
 	append-cppflags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
 }
 
+# @FUNCTION: append-time64-flags
+# @DESCRIPTION:
+# Add flags that enable 64-bit time_t. Implies Large File Support
+# (calls append-lfs-flags) automatically.
+append-time64-flags() {
+        [[ $# -ne 0 ]] && die "append-lfs-flags takes no arguments"
+
+	# time64 needs LFS
+	append-lfs-flags
+
+	append-cppflags -D_TIME_BITS=64
+}
+
 # @FUNCTION: append-ldflags
 # @USAGE: <flags>
 # @DESCRIPTION:
-- 
2.38.1

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: add append-time64-flags

[Mickaël Bucas]

Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :
>
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  eclass/flag-o-matic.eclass | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

> +# @FUNCTION: append-time64-flags
> +# @DESCRIPTION:
> +# Add flags that enable 64-bit time_t. Implies Large File Support
> +# (calls append-lfs-flags) automatically.

Hello Sam

As a simple user, can you explain to me or point me to a resource
about the link between Large File Support and time64 configuration ?

Thanks
Best regards

Mickaël Bucas

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: add append-time64-flags

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]



> On 31 Oct 2022, at 10:37, Mickaël Bucas <mbucas@gmail.com> wrote:
> 
> Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :
>> 
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>> eclass/flag-o-matic.eclass | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
> 
>> +# @FUNCTION: append-time64-flags
>> +# @DESCRIPTION:
>> +# Add flags that enable 64-bit time_t. Implies Large File Support
>> +# (calls append-lfs-flags) automatically.

> Hello Sam
> 

Hi Mickaël,

> As a simple user, can you explain to me or point me to a resource
> about the link between Large File Support and time64 configuration ?
> 

This is a good question -- the answer is two-fold:
1. glibc requires LFS to enable time64
2. Both can involve an ABI break if an off_t or time_t for example
are in an exposed structure, so it's best to do them at the same time.

But I've had second thoughts about this and I want to rethink
if we want to take this approach in the patch I sent.

I think we may want to do a hard-switch for defaults
instead in new profiles. I need to reflect on it a bit more.

Plans and notes are at https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration
if interested!

> Thanks
> Best regards
> 

Best,
sam


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

[gentoo-dev] Re: [PATCH] flag-o-matic.eclass: add append-time64-flags

[Duncan]

Sam James posted on Wed, 9 Nov 2022 06:25:38 +0000 as excerpted:

>> On 31 Oct 2022, at 10:37, Mickaël Bucas <mbucas@gmail.com> wrote:
>> 
>> Le dim. 30 oct. 2022 à 16:48, Sam James <sam@gentoo.org> a écrit :
>>> 
>>> Signed-off-by: Sam James <sam@gentoo.org>
>>> ---
>>> eclass/flag-o-matic.eclass | 13 +++++++++++++
>>> 1 file changed, 13 insertions(+)
>> 
>>> +# @FUNCTION: append-time64-flags
>>> +# @DESCRIPTION:
>>> +# Add flags that enable 64-bit time_t. Implies Large File Support
>>> +# (calls append-lfs-flags) automatically.
> 
>> As a simple user

And as another user...

> Plans and notes are at
> https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration if
> interested!

... just in case anyone (else) needed to be sure, quoting from the above 
link:

>>>> For 32-bit arches <snip>

>>>> Obviously 64-bit arches are already fine. 

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman