From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 12B7A13825A for ; Sun, 15 May 2016 22:56:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B67D1141AD; Sun, 15 May 2016 22:56:06 +0000 (UTC) Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AEDDF21C039 for ; Sun, 15 May 2016 22:56:05 +0000 (UTC) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b24wx-0004Ty-7T for gentoo-dev@lists.gentoo.org; Mon, 16 May 2016 00:55:51 +0200 Received: from ip98-167-165-199.ph.ph.cox.net ([98.167.165.199]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 16 May 2016 00:55:51 +0200 Received: from 1i5t5.duncan by ip98-167-165-199.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 16 May 2016 00:55:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Duncan <1i5t5.duncan@cox.net> Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ Date: Sun, 15 May 2016 22:55:29 +0000 (UTC) Message-ID: References: <1462655928.66afcab271f65b97330e610040ad3acc1b812a03.hd_brummy@gentoo> <1537862.pH6huOSrz0@localhost> <2471981.YXCVhQinPE@localhost> <20160515035327.37fcb81c@tundra.gateway.pace.com> <0c9bfc1f-eae9-b193-62ac-f10995efffff@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip98-167-165-199.ph.ph.cox.net User-Agent: Pan/0.141 (Tarzan's Death; GIT fefda68dd) X-Archives-Salt: 2247b947-301c-4b06-ac90-5b59574564e6 X-Archives-Hash: a6f9a29507d85f96bde26a995a4c4230 Daniel Campbell posted on Sun, 15 May 2016 04:04:57 -0700 as excerpted: > If the dev in question hasn't done that before, then it's entirely > possible they *thought* they tested, or tested it *before* making some > other edit and absent-mindedly committed. Again, legacy CVS thought pattern. In git, commit != push, and it's the push that's critical. Commit all you want without testing. Just test (and fix if necessary) before you push those commits up to the gentoo master repo. =:^) (Of course, rebasing to fold the broken commit and its fix into one before pushing doesn't hurt, either.) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman