[gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[Lucio Sauer]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi,

I wrote patches for infra's git hooks[1] and pkgdev[2] that add two new
commit tags to support the automatic closure of bugs with resolutions
other than FIXED.
However, I am not entirely convinced that the meaning of the chosen tags
is self-evident enough for a third party to understand them at a glance.

Feel free to comment on my propsals or suggest alternatives! You'll
hopefully be using them frequently :)

> Orphans: https://bugs.gentoo.org/####

This commit removes the (last remaining) package that has been affected by
this bug. The bug will be closed with resolution PKGREMOVED.
Unknowing users might think that the bug's assignee will be removed
instead.

Sam also suggested "Removed:" and "Last-rited:"[3].
In my opinion, they don't convey that it's the underlying package that
is being remvoed and not the bug itself.

> Antiquates: https://bugs.gentoo.org/####

This commit removes ebuilds and newer versions of the program are no
longer affected or it drops support for the problematic feature. This
bug will be closed with resolution OBSOLETE.
The tag may more commonly be understood as 'makes old-fashioned', which
doesn't really make sense in this context. Pkgdev would only provide the
long option `--antiq`, which would be a bit shorter than `--obsoletes`.

[1]: https://git.sr.ht/~antecrescent/gentoo-githooks/commit/248ba38802abd9e115a2f602a0cd82b32d16c914
[2]: https://github.com/antecrescent/pkgdev/commit/8e1d84971f0f6c3f638381477de9d99f0c1b2ef3
[3]: https://marc.info/?l=gentoo-dev&m=170737555732280&w=2

Best
-- 
Lucio Sauer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Mon, 2024-06-17 at 09:50 +0000, Lucio Sauer wrote:
> Hi,
> 
> I wrote patches for infra's git hooks[1] and pkgdev[2] that add two new
> commit tags to support the automatic closure of bugs with resolutions
> other than FIXED.
> However, I am not entirely convinced that the meaning of the chosen tags
> is self-evident enough for a third party to understand them at a glance.
> 
> Feel free to comment on my propsals or suggest alternatives! You'll
> hopefully be using them frequently :)
> 

I think it would be less confusing to have an optional arg to Closes,
something like:

  Closes[PKGREMOVED]: ...

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: [gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

>>>>> On Mon, 17 Jun 2024, Michał Górny wrote:

> I think it would be less confusing to have an optional arg to Closes,
> something like:

>   Closes[PKGREMOVED]: ...

Yay, bikeshedding. :) But seriously, since we already have:

  Signed-off-by: ... (DCO-1.1)

I'd suggest using similar syntax, i.e.

  Closes: https://bugs.gentoo.org/123456 (pkgremoved)

The string in parentheses would be matched in a case-insensitive way.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

Re: [gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[Ionen Wolkens]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

On Mon, Jun 17, 2024 at 05:11:03PM +0200, Ulrich Mueller wrote:
> >>>>> On Mon, 17 Jun 2024, Michał Górny wrote:
> 
> > I think it would be less confusing to have an optional arg to Closes,
> > something like:
> 
> >   Closes[PKGREMOVED]: ...
> 
> Yay, bikeshedding. :) But seriously, since we already have:
> 
>   Signed-off-by: ... (DCO-1.1)
> 
> I'd suggest using similar syntax, i.e.
> 
>   Closes: https://bugs.gentoo.org/123456 (pkgremoved)
> 
> The string in parentheses would be matched in a case-insensitive way.

Think I like this version, and let's keep it with no caps please (but
no harm in being case-insensitive & just style indeed).
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

[Lucio Sauer]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Mon, Jun 17, 2024 at 04:57:07PM -0400, Ionen Wolkens wrote:
> On Mon, Jun 17, 2024 at 05:11:03PM +0200, Ulrich Mueller wrote:
> > >>>>> On Mon, 17 Jun 2024, Michał Górny wrote:
> > 
> > > I think it would be less confusing to have an optional arg to Closes,
An optional arg for Closes: is indeed less confusing :^) Thank you!

> > > something like:
> > 
> > >   Closes[PKGREMOVED]: ...
> > 
> > Yay, bikeshedding. :) But seriously, since we already have:
> > 
> >   Signed-off-by: ... (DCO-1.1)
> > 
> > I'd suggest using similar syntax, i.e.
> > 
> >   Closes: https://bugs.gentoo.org/123456 (pkgremoved)
> > 
> > The string in parentheses would be matched in a case-insensitive way.
> 
> Think I like this version, and let's keep it with no caps please (but
> no harm in being case-insensitive & just style indeed).
I ended up going with your combined approaches. Thanks to you too!

-- 
Lucio Sauer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 618 bytes --]