From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-73868-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id E950E1384B4
	for <garchives@archives.gentoo.org>; Fri,  1 Jan 2016 16:58:25 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 7B81721C05E;
	Fri,  1 Jan 2016 16:58:11 +0000 (UTC)
Received: from plane.gmane.org (plane.gmane.org [80.91.229.3])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 746C5E07DB
	for <gentoo-dev@lists.gentoo.org>; Fri,  1 Jan 2016 16:58:10 +0000 (UTC)
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <lnx-gentoo-dev@m.gmane.org>)
	id 1aF31j-0006TP-Bq
	for gentoo-dev@lists.gentoo.org; Fri, 01 Jan 2016 17:58:07 +0100
Received: from ppp118-209-65-208.lns20.mel4.internode.on.net ([118.209.65.208])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <gentoo-dev@lists.gentoo.org>; Fri, 01 Jan 2016 17:58:07 +0100
Received: from kensington by ppp118-209-65-208.lns20.mel4.internode.on.net with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <gentoo-dev@lists.gentoo.org>; Fri, 01 Jan 2016 17:58:07 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: gentoo-dev@lists.gentoo.org
From: Michael Palimaka <kensington@gentoo.org>
Subject: [gentoo-dev] Re: [PATCH 01/15] scons-utils.eclass: Modernize the example not to
 rely on myescons...
Date: Sat, 2 Jan 2016 03:57:59 +1100
Message-ID: <n66b6p$hdh$1@ger.gmane.org>
References: <1451666481-22145-1-git-send-email-mgorny@gentoo.org>
 <1451666481-22145-2-git-send-email-mgorny@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: ppp118-209-65-208.lns20.mel4.internode.on.net
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
In-Reply-To: <1451666481-22145-2-git-send-email-mgorny@gentoo.org>
X-Archives-Salt: 64463dbf-0c99-48c6-8024-2ec2ee708633
X-Archives-Hash: 6d15caa8060d45bf20e8cfd3729c2cca

On 02/01/16 03:41, Michał Górny wrote:
> ---
>  eclass/scons-utils.eclass | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/eclass/scons-utils.eclass b/eclass/scons-utils.eclass
> index a2a6884..e1b3a1b6 100644
> --- a/eclass/scons-utils.eclass
> +++ b/eclass/scons-utils.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2012 Gentoo Foundation
> +# Copyright 1999-2015 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
>  # $Id$
>  
> @@ -17,19 +17,19 @@
>  # EAPI=4
>  #
>  # src_configure() {
> -# 	myesconsargs=(
> +# 	MYSCONS=(
>  # 		CC="$(tc-getCC)"
>  # 		$(use_scons nls ENABLE_NLS)
>  # 	)
>  # }
>  #
>  # src_compile() {
> -# 	escons
> +# 	escons "${MYSCONS[@]}"
>  # }
>  #
>  # src_install() {
>  # 	# note: this can be DESTDIR, INSTALL_ROOT, ... depending on package
> -# 	escons DESTDIR="${D}" install
> +# 	escons "${MYSCONS[@]}" DESTDIR="${D}" install
>  # }
>  # @CODE
>  
> 

What is the benefit of MYSCONS vs myesconsargs? The latter seems to be
more consistent with other eclasses (mycmakeargs, myqmakeargs, ...)