[gentoo-dev] Github PR commenting policy

[gentoo-dev] Github PR commenting policy

[Fernando Rodriguez]

Github allows editting of comments in pull requests. Is there a policy 
regarding that? I've noticed a comment disappear which makes the rest of the 
conversation seem out of place.


-- 
Fernando Rodriguez

Re: [gentoo-dev] Github PR commenting policy

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Dnia 2015-09-18, o godz. 20:09:16
Fernando Rodriguez <frodriguez.developer@outlook.com> napisał(a):

> Github allows editting of comments in pull requests. Is there a policy 
> regarding that? I've noticed a comment disappear which makes the rest of the 
> conversation seem out of place.

We can't really do anything about that. However, we might soon be
mirroring all comments on Bugzilla where removing comments is not
permitted.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] Github PR commenting policy

[Jeroen Roovers]

On Fri, 18 Sep 2015 20:09:16 -0400
Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:

> Github allows editting of comments in pull requests. Is there a
> policy regarding that? I've noticed a comment disappear which makes
> the rest of the conversation seem out of place.

My personal policy is to completely ignore anything Gentoo related that
gets posted on Github. I am also actively contemplating leaving the
Gentoo organisation on Github altogether since it's basically useless
(for reasons such as the one you mentioned) and since we have our own
bug tracker already.


     jer

Re: [gentoo-dev] Github PR commenting policy

[Michał Górny]

Dnia 20 września 2015 11:26:04 CEST, Jeroen Roovers <jer@gentoo.org> napisał(a):
>On Fri, 18 Sep 2015 20:09:16 -0400
>Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
>
>> Github allows editting of comments in pull requests. Is there a
>> policy regarding that? I've noticed a comment disappear which makes
>> the rest of the conversation seem out of place.
>
>My personal policy is to completely ignore anything Gentoo related that
>gets posted on Github. I am also actively contemplating leaving the
>Gentoo organisation on Github altogether since it's basically useless
>(for reasons such as the one you mentioned) and since we have our own
>bug tracker already.

Well, that shouldn't really hurt as most of our users already know that Gentoo developers don't care about them at all.

>
>
>     jer

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] Github PR commenting policy

[Markos Chandras]

On 09/20/2015 10:33 AM, Michał Górny wrote:
> 
> 
> Dnia 20 września 2015 11:26:04 CEST, Jeroen Roovers <jer@gentoo.org> napisał(a):
>> On Fri, 18 Sep 2015 20:09:16 -0400
>> Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
>>
>>> Github allows editting of comments in pull requests. Is there a
>>> policy regarding that? I've noticed a comment disappear which makes
>>> the rest of the conversation seem out of place.
>>
>> My personal policy is to completely ignore anything Gentoo related that
>> gets posted on Github. I am also actively contemplating leaving the
>> Gentoo organisation on Github altogether since it's basically useless
>> (for reasons such as the one you mentioned) and since we have our own
>> bug tracker already.
> 
> Well, that shouldn't really hurt as most of our users already know that Gentoo developers don't care about them at all.
> 

can we please calm down once again?

-- 
Regards,
Markos Chandras

Re: [gentoo-dev] Github PR commenting policy

[Fernando Rodriguez]

On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> Dnia 2015-09-18, o godz. 20:09:16
> Fernando Rodriguez <frodriguez.developer@outlook.com> napisał(a):
> 
> > Github allows editting of comments in pull requests. Is there a policy 
> > regarding that? I've noticed a comment disappear which makes the rest of 
the 
> > conversation seem out of place.
> 
> We can't really do anything about that. However, we might soon be
> mirroring all comments on Bugzilla where removing comments is not
> permitted.

I realize you can't control how users use that feature but there should be 
some policy about how developers use it. I opened at PR because I was asked in 
bugzilla. I received some suggestions to which I replied that most of them are 
not related to my PR but will still do them. After I pushed the changes the 
comment making the suggestions gets deleted.

-- 
Fernando Rodriguez

Re: [gentoo-dev] Github PR commenting policy

[James Le Cuirot]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Sun, 20 Sep 2015 17:53:25 -0400
Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:

> On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> > Dnia 2015-09-18, o godz. 20:09:16
> > Fernando Rodriguez <frodriguez.developer@outlook.com> napisał(a):
> > 
> > > Github allows editting of comments in pull requests. Is there a
> > > policy regarding that? I've noticed a comment disappear which
> > > makes the rest of the 
> > > conversation seem out of place.
> > 
> > We can't really do anything about that. However, we might soon be
> > mirroring all comments on Bugzilla where removing comments is not
> > permitted.
> 
> I realize you can't control how users use that feature but there
> should be some policy about how developers use it. I opened at PR
> because I was asked in bugzilla. I received some suggestions to which
> I replied that most of them are not related to my PR but will still
> do them. After I pushed the changes the comment making the
> suggestions gets deleted.

They are probably not deleted but merely hidden. There should be a
"Show outdated diff" link that will reveal them.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 951 bytes --]

Re: [gentoo-dev] Github PR commenting policy

[Fernando Rodriguez]

On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote:
> On Sun, 20 Sep 2015 17:53:25 -0400
> Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
> 
> > On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> > > Dnia 2015-09-18, o godz. 20:09:16
> > > Fernando Rodriguez <frodriguez.developer@outlook.com> napisał(a):
> > > 
> > > > Github allows editting of comments in pull requests. Is there a
> > > > policy regarding that? I've noticed a comment disappear which
> > > > makes the rest of the 
> > > > conversation seem out of place.
> > > 
> > > We can't really do anything about that. However, we might soon be
> > > mirroring all comments on Bugzilla where removing comments is not
> > > permitted.
> > 
> > I realize you can't control how users use that feature but there
> > should be some policy about how developers use it. I opened at PR
> > because I was asked in bugzilla. I received some suggestions to which
> > I replied that most of them are not related to my PR but will still
> > do them. After I pushed the changes the comment making the
> > suggestions gets deleted.
> 
> They are probably not deleted but merely hidden. There should be a
> "Show outdated diff" link that will reveal them.

Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking about 
deleted comments on Github. I can't find anyway to show them.

-- 
Fernando Rodriguez

Re: [gentoo-dev] Github PR commenting policy

[James Le Cuirot]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

On Sun, 20 Sep 2015 18:54:24 -0400
Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:

> On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote:
> > On Sun, 20 Sep 2015 17:53:25 -0400
> > Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
> > 
> > > On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> > > > Dnia 2015-09-18, o godz. 20:09:16
> > > > Fernando Rodriguez <frodriguez.developer@outlook.com>
> > > > napisał(a):
> > > > 
> > > > > Github allows editting of comments in pull requests. Is there
> > > > > a policy regarding that? I've noticed a comment disappear
> > > > > which makes the rest of the 
> > > > > conversation seem out of place.
> > > > 
> > > > We can't really do anything about that. However, we might soon
> > > > be mirroring all comments on Bugzilla where removing comments
> > > > is not permitted.
> > > 
> > > I realize you can't control how users use that feature but there
> > > should be some policy about how developers use it. I opened at PR
> > > because I was asked in bugzilla. I received some suggestions to
> > > which I replied that most of them are not related to my PR but
> > > will still do them. After I pushed the changes the comment making
> > > the suggestions gets deleted.
> > 
> > They are probably not deleted but merely hidden. There should be a
> > "Show outdated diff" link that will reveal them.
> 
> Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking
> about deleted comments on Github. I can't find anyway to show them.

No, I do mean GitHub. I believe deleted comments really do get deleted
but the ones that seemingly disappear when you amend a commit just get
hidden. See this pull request as an example.

https://github.com/chef-cookbooks/enterprise-chef-common/pull/25

Notice the grey "Show outdated diff" links on right right.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 951 bytes --]

Re: [gentoo-dev] Github PR commenting policy

[Fernando Rodriguez]

On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote:
> On Sun, 20 Sep 2015 18:54:24 -0400
> Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
> 
> > On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote:
> > > On Sun, 20 Sep 2015 17:53:25 -0400
> > > Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
> > > 
> > > > On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
> > > > > Dnia 2015-09-18, o godz. 20:09:16
> > > > > Fernando Rodriguez <frodriguez.developer@outlook.com>
> > > > > napisał(a):
> > > > > 
> > > > > > Github allows editting of comments in pull requests. Is there
> > > > > > a policy regarding that? I've noticed a comment disappear
> > > > > > which makes the rest of the 
> > > > > > conversation seem out of place.
> > > > > 
> > > > > We can't really do anything about that. However, we might soon
> > > > > be mirroring all comments on Bugzilla where removing comments
> > > > > is not permitted.
> > > > 
> > > > I realize you can't control how users use that feature but there
> > > > should be some policy about how developers use it. I opened at PR
> > > > because I was asked in bugzilla. I received some suggestions to
> > > > which I replied that most of them are not related to my PR but
> > > > will still do them. After I pushed the changes the comment making
> > > > the suggestions gets deleted.
> > > 
> > > They are probably not deleted but merely hidden. There should be a
> > > "Show outdated diff" link that will reveal them.
> > 
> > Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking
> > about deleted comments on Github. I can't find anyway to show them.
> 
> No, I do mean GitHub. I believe deleted comments really do get deleted
> but the ones that seemingly disappear when you amend a commit just get
> hidden. See this pull request as an example.
> 
> https://github.com/chef-cookbooks/enterprise-chef-common/pull/25
> 
> Notice the grey "Show outdated diff" links on right right.

I was refering to actual comments, but that's another annoyance. I think that 
link is only shown when somebody references the commit. Mine just disappear 
when I amend a commit. Maybe the QA bot could reference every commit.

-- 
Fernando Rodriguez

Re: [gentoo-dev] Github PR commenting policy

[Alexander Berntsen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 20/09/15 11:26, Jeroen Roovers wrote:
> My personal policy is to completely ignore anything Gentoo related 
> that gets posted on Github.
+1.

- -- 
Alexander
bernalex@gentoo.org
https://secure.plaimi.net/~alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJV//F0AAoJENQqWdRUGk8B0UYQAJQTLtohivP7uP6qi+R3Jk9l
uu9daGevILgQv7kkEg9EM0Bdi9w4Z9Q1ED26x4WRkO5t/feHGiU5m/qE6PBE2XAj
wbSpHOApG++jreC4xPnm+S09PVHV2FKdj0CabNwoU1ZRKIMtRSOreN3KqxC2e9lc
YWNqOPjECiN+HTAod4eCupX6gM/Eoa7Agh9NJtVffeOICyNXa1Jt0DxyWSrqsbnz
8l9yRPfNk2rl6IlPnrMLOmsjWKB+Ta3aZFvIpL0/uqUrfxjTHI0gHFm9Snum5Ev/
fGef51RIDj2qm4K39gF3xx5dIEiBuRUZe/L98N/Mg8eAgSYg1LMVqTPVF7L/Ci5X
o24bxmBKCEcqJHOngUkFrLZ6aCjJNv9r45rO+aFijgwxB5yFzECRkjOhx0gFjDcL
ez4Q5Ipg39KvV0pmbt/DDPOibmjt8DT/f7GoxsYyOj7p06BohyxggPk3Nz8Z+mLK
s3Il0SZrk819A3DT+p2XFj92oUmBcy7stB2Z5jY7ZSQwm87Um6/J9+fnhKtjWo21
LhIxyK2Qz5z6xiv3008j/5YGkbOyQo0bqMjwQwW6xR6k93csao2zvg37ZliLOz+6
H+pXBt4hpaE0qhIzh0vLcAGNNcQd9c+Io4l/gaad3Ji8/pFwqtRG6mIFtnn4Xh6K
MRC9BYnOBI6vhmrTQJPc
=Po7J
-----END PGP SIGNATURE-----

[gentoo-dev] Re: Github PR commenting policy

[selurvedu]

On 21.09.15 02:53, Fernando Rodriguez wrote:
> On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote:
>> On Sun, 20 Sep 2015 18:54:24 -0400
>> Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
>>
>>> On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote:
>>>> On Sun, 20 Sep 2015 17:53:25 -0400
>>>> Fernando Rodriguez <frodriguez.developer@outlook.com> wrote:
>>>>
>>>>> On Saturday, September 19, 2015 7:31:11 AM Michał Górny wrote:
>>>>>> Dnia 2015-09-18, o godz. 20:09:16
>>>>>> Fernando Rodriguez <frodriguez.developer@outlook.com>
>>>>>> napisał(a):
>>>>>>
>>>>>>> Github allows editting of comments in pull requests. Is there
>>>>>>> a policy regarding that? I've noticed a comment disappear
>>>>>>> which makes the rest of the 
>>>>>>> conversation seem out of place.
>>>>>>
>>>>>> We can't really do anything about that. However, we might soon
>>>>>> be mirroring all comments on Bugzilla where removing comments
>>>>>> is not permitted.
>>>>>
>>>>> I realize you can't control how users use that feature but there
>>>>> should be some policy about how developers use it. I opened at PR
>>>>> because I was asked in bugzilla. I received some suggestions to
>>>>> which I replied that most of them are not related to my PR but
>>>>> will still do them. After I pushed the changes the comment making
>>>>> the suggestions gets deleted.
>>>>
>>>> They are probably not deleted but merely hidden. There should be a
>>>> "Show outdated diff" link that will reveal them.
>>>
>>> Are you refering to the "Show Obsolete" link on Bugzilla? I'm talking
>>> about deleted comments on Github. I can't find anyway to show them.
>>
>> No, I do mean GitHub. I believe deleted comments really do get deleted
>> but the ones that seemingly disappear when you amend a commit just get
>> hidden. See this pull request as an example.
>>
>> https://github.com/chef-cookbooks/enterprise-chef-common/pull/25
>>
>> Notice the grey "Show outdated diff" links on right right.
> 
> I was refering to actual comments, but that's another annoyance. I think that 
> link is only shown when somebody references the commit. Mine just disappear 
> when I amend a commit. Maybe the QA bot could reference every commit.
> 

I was curious too about what's an "outdated diff" and why I don't see
those in my pull requests after amending and doing "git push -f", so I
wrote to GitHub support and here's what they replied:

>> Can you explain me what an outdated diff is?
>
> If you comment on a file that was changed as part of a certain pull
> request, and then that file changes again as a result of new commits
> made to the PR's branch, the diff you commented on is now outdated.
> For example:
>
> File A say:
> Heres a diif!
>
> And you comment saying "You're missing an apostrophe!"
>
> And then the user changes File A to say:
> Here's a diff!
>
> Then your comment is now outdated since it was on a file that has
> since been updated.
>
> Hope that was clear!