From: James Cloos <cloos@jhcloos.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: git-2.eclass final review
Date: Sun, 17 Apr 2011 14:31:29 -0400 [thread overview]
Message-ID: <m3r590bug6.fsf@jhcloos.com> (raw)
In-Reply-To: <7066829.Fs6l6Fqv4d@ugly-elf> ("Tomá? Chvátal"'s message of "Sun, 17 Apr 2011 10:44:25 +0200")
That looks good (by inspection).
My only concern is the branch deletion in the non-bare update.
First of all, * should be escaped. It seems to work OK with gnu grep,
but it would be better to be explicit. (grep(1) says that only ?+{|()
loose their meta-meaning in basic regexps.)
Second, why delete the other branches at all? I'd rather have a
complete clone. Just the checkout ought to be enough.
Otherwise, cool.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
next prev parent reply other threads:[~2011-04-17 18:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 21:07 [gentoo-dev] git-2.eclass final review Tomáš Chvátal
2011-03-22 21:26 ` Mike Frysinger
2011-03-22 22:38 ` Tomáš Chvátal
2011-03-22 23:08 ` Mike Frysinger
2011-03-22 23:41 ` [gentoo-dev] " Ryan Hill
2011-03-22 23:45 ` Ryan Hill
2011-03-22 23:55 ` Mike Frysinger
2011-03-23 12:28 ` James Cloos
2011-03-23 13:01 ` Tomáš Chvátal
2011-03-23 14:44 ` James Cloos
2011-03-24 12:54 ` Donnie Berkholz
2011-03-23 16:29 ` Donnie Berkholz
2011-03-24 10:52 ` James Cloos
2011-03-23 0:42 ` [gentoo-dev] " Tomáš Chvátal
2011-03-31 4:55 ` Jeroen Roovers
2011-03-31 6:32 ` Tomáš Chvátal
2011-03-31 7:29 ` Fabian Groffen
2011-03-31 16:00 ` Matt Turner
2011-03-31 21:23 ` Aaron W. Swenson
2011-04-05 15:18 ` Marc Schiffbauer
2011-04-17 8:44 ` [gentoo-dev] " Tomá? Chvátal
2011-04-17 18:31 ` James Cloos [this message]
2011-04-18 9:45 ` Tomáš Chvátal
2011-04-18 17:55 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r590bug6.fsf@jhcloos.com \
--to=cloos@jhcloos.com \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox