From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NRFej-0005pC-19 for garchives@archives.gentoo.org; Sun, 03 Jan 2010 01:53:21 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8204CE0549; Sun, 3 Jan 2010 01:51:49 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3F978E0549 for ; Sun, 3 Jan 2010 01:51:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id F16AE67CC7 for ; Sun, 3 Jan 2010 01:51:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at gentoo.org X-Spam-Score: -0.912 X-Spam-Level: X-Spam-Status: No, score=-0.912 required=5.5 tests=[AWL=-1.501, BAYES_00=-2.599, FH_DATE_PAST_20XX=3.188] Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jj6dbjDMe0ep for ; Sun, 3 Jan 2010 01:51:40 +0000 (UTC) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 3BE0967860 for ; Sun, 3 Jan 2010 01:51:38 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.50) id 1NREm0-0007OW-5U for gentoo-dev@gentoo.org; Sun, 03 Jan 2010 01:56:48 +0100 Received: from 87-194-16-43.bethere.co.uk ([87.194.16.43]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Jan 2010 01:56:48 +0100 Received: from couldbe by 87-194-16-43.bethere.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 03 Jan 2010 01:56:48 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Mark Bateman Subject: [gentoo-dev] Re: [RFC] base.eclass Date: Sun, 3 Jan 2010 00:56:25 +0000 (UTC) Message-ID: References: <4B3F6BB5.1030703@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: sea.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 87.194.16.43 (Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.6) Gecko/20091221 Gentoo Shiretoko/3.5.6 GTB6) Sender: news Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 6e89aeef-297c-4233-9824-17f3b524d19b X-Archives-Hash: c95aea63a6a5d13180d5cf02042a6077 Tom=C3=A1=C5=A1 Chv=C3=A1tal gentoo.org> writes: >=20 > Hola, > I have incorporated all fixes to base.eclass that has been itching me > for a while (closes both open bugs). >=20 > Whats new: > * base_src_install docs > this thingie install docs and html_docs from bash array defined in > global scope (or anywhere else indeed :P) >=20 > * all bash variable arrays including the PATCHES one have support for > folders >=20 > * using same codestyle everywhere... >=20 > * using pushd/popd instead of cd >=20 > Diff and full eclass attached. >=20 > Living link: > http://git.overlays.gentoo.org/gitweb/?p=3Dproj/kde.git;a=3Dblob;f=3Dec= lass/base.eclass >=20 There seems to be alot of unquoted variables 65 base_src_util $@ 90 case $1 in 95 [[ ! -z "${A}" ]] && unpack ${A} 117 oldval=3D${EPATCH_SOURCE} 118 EPATCH_SOURCE=3D${x} 120 EPATCH_SOURCE=3D${oldval} Also a typo: an "n" slipped in 130 popd > n/dev/null