[gentoo-dev] Re: [RFC] base.eclass

[Mark Bateman <couldbe@soon.com>]

Tomáš Chvátal <scarabeus <at> gentoo.org> writes:

> 
> Hola,
> I have incorporated all fixes to base.eclass that has been itching me
> for a while (closes both open bugs).
> 
> Whats new:
> * base_src_install docs
> this thingie install docs and html_docs from bash array defined in
> global scope (or anywhere else indeed :P)
> 
> * all bash variable arrays including the PATCHES one have support for
> folders
> 
> * using same codestyle everywhere...
> 
> * using pushd/popd instead of cd
> 
> Diff and full eclass attached.
> 
> Living link:
> http://git.overlays.gentoo.org/gitweb/?p=proj/kde.git;a=blob;f=eclass/base.eclass
> 

There seems to be alot of unquoted variables

65                 base_src_util $@

90                 case $1 in

95                                 [[ ! -z "${A}" ]] && unpack ${A}


 117   oldval=${EPATCH_SOURCE}
 118   EPATCH_SOURCE=${x}

 120   EPATCH_SOURCE=${oldval}


Also a typo: an "n" slipped in
130                                 popd > n/dev/null