From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1JcloA-0000H1-R2 for garchives@archives.gentoo.org; Fri, 21 Mar 2008 18:17:39 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F08F4E0634; Fri, 21 Mar 2008 18:17:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A8521E0634 for ; Fri, 21 Mar 2008 18:17:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 4A475673B6 for ; Fri, 21 Mar 2008 18:17:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at gentoo.org X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.5 tests=[AWL=0.699, BAYES_00=-2.599] Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9oyo2kJNWVvq for ; Fri, 21 Mar 2008 18:17:28 +0000 (UTC) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id BB7466757B for ; Fri, 21 Mar 2008 18:17:25 +0000 (UTC) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Jclnn-0007ss-Pt for gentoo-dev@gentoo.org; Fri, 21 Mar 2008 18:17:15 +0000 Received: from static24-72-115-196.yorkton.accesscomm.ca ([24.72.115.196]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 21 Mar 2008 18:17:15 +0000 Received: from dirtyepic by static24-72-115-196.yorkton.accesscomm.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 21 Mar 2008 18:17:15 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Ryan Hill Subject: [gentoo-dev] Re: Remaining PMS todo list etc Date: Fri, 21 Mar 2008 12:17:04 -0600 Message-ID: References: <20080319182717.69c0f975@snowcone> <20080320044503.3c29a663@sheridan.genone.homeip.net> <20080321075426.54db71b1@googlemail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA819E39548458650F4607C6E" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: static24-72-115-196.yorkton.accesscomm.ca User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080227 Thunderbird/2.0.0.12 Mnenhy/0.7.5.0 In-Reply-To: <20080321075426.54db71b1@googlemail.com> X-Enigmail-Version: 0.95.6 OpenPGP: id=F9A40662; url=subkeys.pgp.net Sender: news X-Archives-Salt: 6ceb623d-3787-4bf4-90e4-05dfe99b9ca7 X-Archives-Hash: a18fad9f458de31e7e0a9ae2ed62ce1d This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA819E39548458650F4607C6E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Ciaran McCreesh wrote: > On Thu, 20 Mar 2008 18:02:31 -0600 > Ryan Hill wrote: >>> How about just checking EUID =3D=3D 0 in src_test and skip the tests >>> (with a ewarn message) if it doesn't match your needs? >> I thought I remembered someone raising a stink about checking >> permissions being a race condition because the condition can change >> between the checking and performing the action. Maybe that was only >> about write permissions... >=20 > That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a > variable that's constant for the phase is not racy. >=20 >> If checking EUID is an acceptable method, >> it should be relatively simple to write an eclass to handle the >> common cases and have ebuilds use that instead of checking $FEATURES >> (which i do think is a bug). >=20 > Does it really need an eclass for something so simple? Considering the number of ebuilds that check FEATURES, disable tests alto= gether,=20 or just do nothing and fail for half our users, against the number that= do it=20 correctly... apparently yeah. The simpler we make it to use, the more = people=20 will use it. On the other hand, it might be better to just document the common cases a= long=20 with some example code in the Dev Guide. I'd be happy with doing that. --=20 fonts, gcc-porting, by design, by neglect mips, treecleaner, for a fact or just for effect wxwidgets @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662 --------------enigA819E39548458650F4607C6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFH4/uhiqiDRvmkBmIRCDeCAJ99CBteRENaE0i4d/k152AZd2YpDgCgowbC /hm+1OT341x3rztSa6zGmV8= =w4G8 -----END PGP SIGNATURE----- --------------enigA819E39548458650F4607C6E-- -- gentoo-dev@lists.gentoo.org mailing list