[gentoo-dev] Re: Remaining PMS todo list etc

[Ryan Hill <dirtyepic@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

Ciaran McCreesh wrote:
> On Thu, 20 Mar 2008 18:02:31 -0600
> Ryan Hill <dirtyepic@gentoo.org> wrote:
>>> How about just checking EUID == 0 in src_test and skip the tests
>>> (with a ewarn message) if it doesn't match your needs?
>> I thought I remembered someone raising a stink about checking
>> permissions being a race condition because the condition can change
>> between the checking and performing the action.  Maybe that was only
>> about write permissions...
> 
> That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a
> variable that's constant for the phase is not racy.
> 
>> If checking EUID is an acceptable method,
>> it should be relatively simple to write an eclass to handle the
>> common cases and have ebuilds use that instead of checking $FEATURES
>> (which i do think is a bug).
> 
> Does it really need an eclass for something so simple?

Considering the number of ebuilds that check FEATURES, disable tests altogether, 
  or just do nothing and fail for half our users, against the number that do it 
correctly...   apparently yeah.  The simpler we make it to use, the more people 
will use it.

On the other hand, it might be better to just document the common cases along 
with some example code in the Dev Guide.  I'd be happy with doing that.


-- 
fonts, gcc-porting,                               by design, by neglect
mips, treecleaner,                        for a fact or just for effect
wxwidgets @ gentoo     EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]