From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IhXKz-0008Cf-Id for garchives@archives.gentoo.org; Mon, 15 Oct 2007 21:18:58 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9FL7qEi016813; Mon, 15 Oct 2007 21:07:52 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9FL5t6k014506 for ; Mon, 15 Oct 2007 21:05:56 GMT Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id B694865616 for ; Mon, 15 Oct 2007 21:05:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at gentoo.org X-Spam-Score: 0.722 X-Spam-Level: X-Spam-Status: No, score=0.722 required=5.5 tests=[AWL=-0.235, BAYES_05=-1.11, RCVD_NUMERIC_HELO=2.067] Received: from smtp.gentoo.org ([127.0.0.1]) by localhost (smtp.gentoo.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mFSbN2PBThq5 for ; Mon, 15 Oct 2007 21:05:49 +0000 (UTC) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id C6A6C655FC for ; Mon, 15 Oct 2007 21:05:47 +0000 (UTC) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IhX3n-0001Gs-Hj for gentoo-dev@gentoo.org; Mon, 15 Oct 2007 21:01:12 +0000 Received: from 82.153.64.56 ([82.153.64.56]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Oct 2007 21:01:11 +0000 Received: from slong by 82.153.64.56 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 15 Oct 2007 21:01:11 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: gentoo-dev@lists.gentoo.org From: Steve Long Subject: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild Date: Mon, 15 Oct 2007 21:57:07 +0100 Message-ID: References: <20071013004453.GM23990@supernova> <4711974B.6010505@gentoo.org> <20071014045010.GS23990@supernova> <47137651.8040503@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82.153.64.56 User-Agent: KNode/0.10.4 Sender: news X-Archives-Salt: e7b5844c-53c9-4caf-9070-dd7458b51bd6 X-Archives-Hash: 01b760bbd297859eda19450347071f83 Doug Goldstein wrote: > I know the other thing I didn't answer was the fact that some variables > aren't quoted. It doesn't matter at all considering their configure > script can't handle spaces in the path names anyway. We've been though > that already. Additionally, qmake can't handle spaces in there even if > you do quote so it really doesn't matter much. > I disagree: it's important to do the correct thing, wrt spaces in filenames, in scripts, since there is a well-understood method of doing so (quoting) and once it is correct, it is always correct no matter what use is made of it in the future. If upstream tools can't deal with them, then they need to be fixed. I appreciate that might not happen for this configure script, but it shoud happen for qmake. (I find it hard to believe that qmake can't deal with spaces in filenames tbh, not from experience: it just sounds amateurish.) > Some of these review changes truly feel like working at a company where > you know the ins and outs of your tool. You can rattle off its > capabilities to a millimeter. A new boss/manager comes in and has no > idea what the tool is or the mission but by god he knows how to do your > job better and you will follow his procedures. It makes no difference if > his steps have no effect on the tool and waste more of your time. You > additionally have to start giving him progress reports on how you're > doing using his procedures, which instantly means you get less work done. > > That's what this commits review list feels like. Fair enough: that's how you feel about it. The quoting issue isn't new though[1]: that it hasn't been picked up on before is no excuse for not fixing it now, imo. The tool in question is bash, not the upstream configure script or qmake, and correct usage should be a point of pride: again, only my opinion. Then again, no-one's making you report back-- you're not under any contractual obligation to respond: must just be professional pride? ;-) [1] http://www.grymoire.com/Unix/Quote.html http://bash-hackers.org/wiki/doku.php?id=syntax:words explains why and how the issue arises. -- gentoo-dev@gentoo.org mailing list