From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-87324-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 5D292138334
	for <garchives@archives.gentoo.org>; Sun,  9 Jun 2019 16:13:15 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id E59CBE089E;
	Sun,  9 Jun 2019 16:13:10 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 99BD3E0887
	for <gentoo-dev@lists.gentoo.org>; Sun,  9 Jun 2019 16:13:10 +0000 (UTC)
Received: from [192.168.1.100] (c-98-218-46-55.hsd1.md.comcast.net [98.218.46.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: mjo)
	by smtp.gentoo.org (Postfix) with ESMTPSA id BE5E3345ADA
	for <gentoo-dev@lists.gentoo.org>; Sun,  9 Jun 2019 16:13:08 +0000 (UTC)
Subject: Re: [gentoo-dev] [PATCH v3 11/19] user.eclass: Also permit using
 functions in pkg_*rm phases
To: gentoo-dev@lists.gentoo.org
References: <20190609112814.15907-1-mgorny@gentoo.org>
 <20190609112814.15907-12-mgorny@gentoo.org>
From: Michael Orlitzky <mjo@gentoo.org>
Message-ID: <fe217950-d2cf-7115-66bd-51351a9de605@gentoo.org>
Date: Sun, 9 Jun 2019 12:12:58 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
In-Reply-To: <20190609112814.15907-12-mgorny@gentoo.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Archives-Salt: 71491272-855c-4448-8b90-c17500a5cefc
X-Archives-Hash: d90868f70e4e36461dcf39887849f525

On 6/9/19 7:28 AM, Michał Górny wrote:
>  _assert_pkg_ebuild_phase() {
>  	case ${EBUILD_PHASE} in
> -	setup|preinst|postinst) ;;
> +	setup|preinst|postinst|prerm|postrm) ;;
>  	*)
>  		eerror "'$1()' called from '${EBUILD_PHASE}' phase which is not OK:"
>  		eerror "You may only call from pkg_{setup,preinst,postinst} functions."
> 

The error message needs an update, too.