From: "Maciej Barć" <xgqt@gentoo.org>
To: "Michał Górny" <mgorny@gentoo.org>, gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/7] eclass/dotnet-pkg-utils.eclass: introduce new eclass
Date: Sun, 30 Jul 2023 22:04:01 +0200 [thread overview]
Message-ID: <fb7c32cc-2281-128e-f77c-49cdcd13437d@gentoo.org> (raw)
In-Reply-To: <2bcae9ebef884b25c7d3dd60bd29b35a60032da1.camel@gentoo.org>
W dniu 30.07.2023 o 21:34, Michał Górny pisze:
> On Sun, 2023-07-30 at 16:26 +0200, Maciej Barć wrote:
>> Bug: https://bugs.gentoo.org/900597
>> Bug: https://github.com/gentoo/gentoo/pull/29309
>> Signed-off-by: Maciej Barć <xgqt@gentoo.org>
>> ---
>> eclass/dotnet-pkg-utils.eclass | 602 +++++++++++++++++++++++++++++++++
>> 1 file changed, 602 insertions(+)
>> create mode 100644 eclass/dotnet-pkg-utils.eclass
>>
>> diff --git a/eclass/dotnet-pkg-utils.eclass b/eclass/dotnet-pkg-utils.eclass
>> new file mode 100644
>> index 000000000..bdde11fe5
>> --- /dev/null
>> +++ b/eclass/dotnet-pkg-utils.eclass
>> @@ -0,0 +1,602 @@
>> +# Copyright 1999-2023 Gentoo Authors
>> +# Distributed under the terms of the GNU General Public License v2
>> +
>> +# @ECLASS: dotnet-pkg-utils.eclass
>> +# @MAINTAINER:
>> +# Gentoo Dotnet project <dotnet@gentoo.org>
>> +# @AUTHOR:
>> +# Anna Figueiredo Gomes <navi@vlhl.dev>
>> +# Maciej Barć <xgqt@gentoo.org>
>> +# @SUPPORTED_EAPIS: 8
>> +# @PROVIDES: nuget
>> +# @BLURB: common functions and variables for builds using .NET SDK
>> +# @DESCRIPTION:
>> +# This eclass is designed to provide common definitions for .NET packages.
>> +#
>> +# This eclass does not export any phase functions, for that see
>> +# the "dotnet-pkg" eclass.
>
> Given how intrusive this is, I don't think "-utils" is a correct suffix.
> It's for eclasses providing utility functions without affecting packages
> implicitly.
>
What about "-common", like "elisp-common.eclass" has?
Any suggestion?
BTW: I will not merge dotnet-pkg and dotnet-pkg-utils because then we
will get the most perfect spaghetti-code-soup-thing known to men.
--
Have a great day!
~ Maciej XGQT Barć
xgqt@gentoo.org
Gentoo Linux developer
(dotnet, emacs, math, ml, nim, scheme, sci)
https://wiki.gentoo.org/wiki/User:Xgqt
9B0A 4C5D 02A3 B43C 9D6F D6B1 14D7 4A1F 43A6 AC3C
next prev parent reply other threads:[~2023-07-30 20:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 14:26 [gentoo-dev] [PATCH 1/7] eclass/nuget.eclass: introduce new eclass Maciej Barć
2023-07-30 14:26 ` [gentoo-dev] [PATCH 2/7] eclass/dotnet-pkg-utils.eclass: " Maciej Barć
2023-07-30 19:34 ` Michał Górny
2023-07-30 20:04 ` Maciej Barć [this message]
2023-07-31 5:09 ` Michał Górny
2023-07-30 14:26 ` [gentoo-dev] [PATCH 3/7] eclass/dotnet-pkg.eclass: " Maciej Barć
2023-07-31 9:20 ` Thomas Bracht Laumann Jespersen
2023-07-30 14:26 ` [gentoo-dev] [PATCH 4/7] dev-dotnet/dotnet-runtime-nugets: new package Maciej Barć
2023-07-30 14:26 ` [gentoo-dev] [PATCH 5/7] app-eselect/eselect-dotnet: " Maciej Barć
2023-07-30 14:26 ` [gentoo-dev] [PATCH 6/7] dev-dotnet/dotnet-sdk-bin: update packaging mechanism Maciej Barć
2023-07-30 14:26 ` [gentoo-dev] [PATCH 7/7] dev-dotnet/dotnet-sdk-bin: drop old Maciej Barć
2023-07-30 19:30 ` [gentoo-dev] [PATCH 1/7] eclass/nuget.eclass: introduce new eclass Michał Górny
2023-07-30 20:01 ` Maciej Barć
2023-07-31 5:08 ` Michał Górny
2023-07-30 20:19 ` Florian Schmaus
2023-07-31 5:02 ` Michał Górny
2023-07-31 7:53 ` Florian Schmaus
2023-07-31 9:32 ` Sam James
2023-07-31 10:49 ` Florian Schmaus
2023-07-31 11:39 ` Sam James
2023-07-31 13:53 ` Michał Górny
2023-07-31 14:20 ` Florian Schmaus
-- strict thread matches above, loose matches on Subject: below --
2023-07-16 12:38 Maciej Barć
2023-07-16 12:38 ` [gentoo-dev] [PATCH 2/7] eclass/dotnet-pkg-utils.eclass: " Maciej Barć
2023-07-16 12:48 ` Sam James
2023-07-16 13:35 ` Maciej Barć
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7c32cc-2281-128e-f77c-49cdcd13437d@gentoo.org \
--to=xgqt@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox