From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] Revisiting GLEP 81 (acct-*) policies (reviews, cross-distro syncing)
Date: Tue, 10 Dec 2019 14:34:25 +0100 [thread overview]
Message-ID: <fb43d3ec3aa6443cec69b28b3ee51bce798409e1.camel@gentoo.org> (raw)
In-Reply-To: <6f1dc9b3-e13e-1186-f75a-51615db505d3@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 3544 bytes --]
On Tue, 2019-12-10 at 07:44 +0200, Joonas Niilola wrote:
> Hey,
>
> On 12/9/19 10:17 AM, Michał Górny wrote:
> > Hello,
> >
> > I think the policies proposed in GLEP 81 [1] were overenthusiastic
> > and they don't stand collision with sad Gentoo developer reality.
> > Instead of improving the quality of resulting packages, they rather
> > hamper their adoption and cause growing frustration.
> >
> > The problems I see today are:
> >
> >
> > 2. Mailing list reviews don't serve their original purpose.
> >
> > The original purpose of mailing list reviews was to verify that
> > the developers use new packages correctly. For example, Michael
> > Orlitzky has found a lot of unnecessary home directories specified.
> > Of course, that works only if people submit *ebuilds* for review.
> >
> > However, at some points developers arbitrarily decided to send only
> > numbers for review. This defeats the purpose of the review in the first
> > place.
>
> The problem: There is still no any official documentation about using
> acct-, and reviewing it was/is pretty much left on the shoulders of one
> man. It's easy to say on hindsight it was implemented too quickly.
There is official documentation in devmanual [1].
> >
> > 4. Assignment mechanism is not collision-prone.
> >
> > The secondary goal of mailing list reviews is to prevent UID/GID
> > collisions. Sadly, it doesn't work there either. Sometimes two people
> > request the same UID/GID, and only sometimes somebody else notices.
> > In the end, people have hard time figuring out which number is the 'next
> > free', sometimes they discover the number's been taken when somebody
> > else commits it first.
>
> If I remember correctly, at one point it was agreed not to paste ebuilds
> because they all just looked similar, but just ask for IDs?
I wouldn't call it 'agreed'. Someone said something, people stopped
doing. Nobody bothered updating the policy (in GLEP 81, the rationale
explains it [2]).
> > All that considered, I'd like to open discussion how we could improve
> > things.
> >
> > My proposal would be to:
> >
> > a. split the UID/GID range into 'high' (app) and 'low' (system)
> > assignments, 'high' being >=100 and 'low' <100 (matching Apache suEXEC
> > defaults),
> >
> > b. UIDs/GIDs in the 'high' range can be taken arbitrarily (recommending
> > taking highest free), while in the 'low' range must be approved by QA,
> >
> > c. no review requirement for the 'high' range, just choose your UID/GID
> > straight of uid-gid.txt and commit it,
> >
> > d. strong recommendation to use matching UID/GID for the same user/group
> > name.
> >
> > WDYT?
> >
> >
> > [1] https://www.gentoo.org/glep/glep-0081.html
>
> I think none of the above really prevent collisions for unmotivated
> people. They also still require manual update of uid-gid.txt, and it
> can't be expected everyone does it. Now this is not of a big interest to
> devs, but I believe committing non-dev acct's will get hard here,
> because there might be some "lag" with their contributions vrt. the
> current situation.
>
Hence my idea that if we stop requiring mailing list RFC, we can replace
that with obligatory update to uid-gid.txt. It should work good enough
for synchronization.
[1] https://devmanual.gentoo.org/ebuild-writing/users-and-groups/index.html
[2] https://www.gentoo.org/glep/glep-0081.html#requiring-mailing-list-rfc
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2019-12-10 13:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 8:17 [gentoo-dev] [RFC] Revisiting GLEP 81 (acct-*) policies (reviews, cross-distro syncing) Michał Górny
2019-12-09 9:44 ` Ulrich Mueller
2019-12-09 10:00 ` Ulrich Mueller
2019-12-09 16:54 ` Thomas Deutschmann
2019-12-09 17:47 ` Ulrich Mueller
2019-12-09 18:02 ` Thomas Deutschmann
2019-12-09 18:48 ` Ulrich Mueller
2019-12-09 20:10 ` Thomas Deutschmann
2019-12-10 14:36 ` Michael Orlitzky
2019-12-09 21:48 ` Alec Warner
2019-12-10 5:28 ` Michał Górny
2019-12-10 5:44 ` Joonas Niilola
2019-12-10 11:47 ` Rich Freeman
2019-12-10 12:26 ` Thomas Deutschmann
2019-12-10 12:44 ` Rich Freeman
2019-12-10 13:25 ` Thomas Deutschmann
2019-12-10 13:48 ` Rich Freeman
2019-12-10 16:05 ` Joonas Niilola
2019-12-10 16:25 ` Michael Orlitzky
2019-12-10 13:34 ` Michał Górny [this message]
2019-12-10 16:13 ` Joonas Niilola
2019-12-10 16:17 ` Michał Górny
2019-12-10 14:50 ` Michael Orlitzky
2019-12-10 15:04 ` Michał Górny
2019-12-10 15:54 ` Rich Freeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb43d3ec3aa6443cec69b28b3ee51bce798409e1.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox