From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2E7BF158170 for ; Fri, 19 Jul 2024 10:31:10 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6E558E2A5B; Fri, 19 Jul 2024 10:31:05 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 15940E2A4B for ; Fri, 19 Jul 2024 10:31:05 +0000 (UTC) Message-ID: Subject: Re: [gentoo-dev] [RFC PATCH 04/19] www-servers/nginx: add nginx-r5.initd From: Michael Orlitzky To: gentoo-dev@lists.gentoo.org Date: Fri, 19 Jul 2024 06:31:01 -0400 In-Reply-To: <347alr7mlwdxkyxfx6fxyki3ywb2cae2otzb74yd374ds4jelr@a425qznt4gta> References: <20240717120553.31866-1-zurabid2016@gmail.com> <20240717120553.31866-5-zurabid2016@gmail.com> <16a8315d4c23c3d6bd549c431a2362253a9b860e.camel@gentoo.org> <347alr7mlwdxkyxfx6fxyki3ywb2cae2otzb74yd374ds4jelr@a425qznt4gta> Autocrypt: addr=mjo@gentoo.org; prefer-encrypt=mutual; keydata=mQINBEuhJiIBEACzkBTbfQpsmcbAMlzcRu9b8nuGKxGK0CJzChH6IHo0N0eLPYab8CnRoXL46N7Wi4QKKO9h3YlSjyJU/hUV7y9DZ9Y1WtXAZW7cjUAzUW8sXj+JU2LyFRsqtq/NM8xT/DIhVvXyzdH/sp28uHkERSxyeMeM5SEGKo5+BLeW7VplIg8PzdHdsv/0k/etDlGo1N66E+pEP2gyT7pK/9iODwhFXbIJFfPbrOdfI7UtEgvuUjVW5uAUd/cBkLCQihnpt+/F8LpIA7fG9ZcwVV6Ni48uawn4cXA6S8JrFjzlxkxj6mgK9e+7rMptWlM3ZnmhxS1f29quSNJtswbXpV5CK3iXMr2WXMvhMvph6Kb0COLDy0lHbTbRFEyQuTebk/+ZqGNTM3q7CqjzjSHfrcuB79/IVzAltxEONpcd91SJXUNALQW4j6W+f/ptia6smfVpMxDXGWoSaBID6lGKaucMyZN47xms6rbaCWwHyIqo8uaEexWlbrBi4yPJphIsYIe/HeKz3Dqlz2CAIR9Ocr1Azk0HDpVxu6TUJ+2ThoLM/tkU+ptz5icYXU/TfDEmq6Mb/wOHp5svnO7faOSnG5sEN0MMaXd+uZhEbfDhZtzuQDzMBYqXcaOUWr3LkhsH0H7VEoV8e/PedmK2Xv6rAXkYbVqjjeP+kARRH5WKouLtkRtzZwARAQABtCdNaWNoYWVsIE9ybGl0emt5IDxtaWNoYWVsQG9ybGl0emt5LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAhkBFiEEazyTN0u7P1V4+6xJHElyTSKek6IFAmNpVEIFCRuKlSAACgkQHElyTSKek6KlOg//c93T/s5ZfH5UUpdMJsXeRYpWBot9Pw8TO8Iev0HnIp347yQpMji9Gts2nrfBv1021t6yvVF/6i1uYEKuXoCuZoVbXaoH0i1ZFK620pqo4EdyQ CTNxnHIp1cznlLnntgsrnT2DFLizFK2HH3bZrhRJe79Rw51ITFzrl+ndaDWIh0K8jGeTfg7YRBdr6pp4VsiGYd8HcepbYgpGbjT/eR5JDGspstsxWzxsuK9HjRYTP+rtx4VySOJz6j48dmy1/exqSV/UP1ePakXepJkatsY19G0ZHpI+LniG1KVKHzAVVjlmEHb4BR54M14dFbda8wNAm0DbNpqOwclkWefW8Efn9M1DdJC7jmZJJKoaZp6abthE8sBR6pKOkGrVP9eVSvFZLRrBzGMH8LLoc38C2SqjFOln6YU/dUKmHha89lyC7I6WqKMIZHUG/GJIZ/qSCsI6s1b3te0ingRpfNtomQVNXsIgobfanOSlWpq231vFMvrneXgcq/CdHi3qLOvARgLAQ/26J6fqsBPLMToIDyICFMIIWkk8S3Z9QDswoaZ+XNvXXM32ZNW3lPMNK875xoYr1X4D2HRfWbBRLEswotmhZvq4aXff0EPUhEuvFVT9m237uQoEaM7HNleHBDkXV6nr01LOmWFysdX81mvGsmIQnuKNRTGD6q2e9mrEkWM/Y20IU1pY2hhZWwgT3JsaXR6a3kgPG1qb0BnZW50b28ub3JnPokCVAQTAQgAPgIbAwULCQgHAwUVCgkICwUWAwIBAAIeAQIXgBYhBGs8kzdLuz9VePusSRxJck0inpOiBQJjaVREBQkbipUgAAoJEBxJck0inpOiFHgP/jZAOaLLC2bkL8b8PN1kZTGaO6MMuRUc13mqGQgJ+snOu09fit/jF15Whc3V1bDwfYe59+vUMhLKndCXDuU7pWlywXy81Ym9IzZ/hIcTsjXoo6KStE4pzQ4oFsqFDJzgbK/MoKmfqKKbOu4AYNmwrJSMPjdiA/0fxRzhoqgRNQ2h5FFjbIwFzQOkllvuHBLepegB82vTbnL+g/EunmgMp66QGXXY1YOzhGq5vxp6Dg7VnuSXlXLPfXE1NQX3eb886kb+gt GnIJo12aJ/qf3u70MxoVDcwnYvL8fiZ66iWmH1O2E3ngGi99FXEdYuIsfzIYpMlarDuZq3H6tFR1DXwurkLN1767YmEufcMjnMM5C68i3P0NE5I717tVJB1Y/TmDLZhyuFc+QqNxsFiYLOlMwCunTo2JKBYlZVoHGkuDUSfxUwgCht7jxxMdSOifJXXeCc0jm3mMw0B0oD5mWp40H4pGrNLxsfGggqQdRAE1vK6Uo1ciamxkjsjd7UUUvFr8ptnHDYsESHg8wPoCgPrGvqFjjDLEuTdktPV1z3Uy9pOVZppyHdmWTIz+BtZWQcRdBEr0WMN86ompIu4XieinFfzYUrWq8AKI6yamme2RxrB/T4kbNL0tg9XJajKglKTNOV+QQbki6HqiWnQQpLS88/8yvB8lJR/S2JQspH1LWyuQINBEuhJiIBEAD3PZc+V6EdBn5aPJErRmn91sycSEYMP+e2nXEdTykyi/XNT4xnC3LJ8hBcG03Ziku8wxv8wlRei/mzkXBLF1ORlUvEIGRQgQIN1oMMMLQlrWiQnk1qoqFM0QOwuMwqx7SbMmSk+1Ki1xf3EPumHW4+XQ0tTAE854fzU0ek2XsAPd0z990UfE4uQcSvznbqk7kGeqOyL+MBIGXjR4dx7BHB5e936FWZfWKbEPYXU0R+tYkyjoR0KxgUIHOE4GPHCJna7QyfpwoP0A9s9H9nkM4SzWl+uUt9ys1+C2lsA9Dg8sIofM0BtHUpxzgsOwm/yJ+UlCiqHttVYxH74x25Jgt25U5j/plKkGsiT6ajIKqCJC8aRBLLbXMACb+uAr5WN0piILfg/K1N3vCRx1PbtNTwhAxzm0Hl17ZqYmECk/EMZ9s5OvBhi2JetiE6pWncNMqnIFdHtCI1KRrOcyYQ13dDYKJ2B4RhkHiHRQMxTjhH79TAE7xLb0xbHWsu3Gx0TkST+PTKY4hr6/G7p9lGcNhS9FTWNDcurjPG9iOjVVh/zl+w6LP LypUEIeq6rcfZPichKRqWqIDoXt+uCllKXzvJtbeIi0hGSDGcc+iB+iO+DiLDuWFfZBZYt5QfyzWmsrGUtGFokeED9k3vg/BJ5jJnHFKu/Kv+WDMA5iZOrXizYQARAQABiQI8BBgBCAAmAhsMFiEEazyTN0u7P1V4+6xJHElyTSKek6IFAmNpVFkFCRuKlTcACgkQHElyTSKek6JhOw//a0braTMkv0pfiKS8PmRzt0pHwMhcoxkc9T8RSyIqCO4gRjw1xJM5wzoU9EEBbnbNcesYMKcH60ojGACRRwXLoUNGleFgAcF/7IwXWTp01h66fovacpv/NbOSAg+uHmm0Wn2ARElri/wrBEMP55FGyyPA0uzN/BrEPCMUrg6RsVYNimaowNsQIzjK24RqMUMBhfPWWpfao9xHuog0Q4Z4yMFE3kizujuf82yY6aSYJ3Di5TbeN4zxn7TInpvsHXC86aia+jdSgc0plGUg08De2rxIZ6AuGtne15k1oWnOL8+X/tyU9GvA772cUI5Zj/s0/6gYvgDYo4BFcWJRGEVNqG2uzhA5qU0kC1BYfWckmLoTx75wBri7PzR2JSN5rUqno2TbPr0zbsmv4r4253G8NrpphosrTFQbXPqpLc/gXLMwFKwpHP+ZzktK0ycKHlTGdCtbcvf/ycdoFjQW/dO4Usp/h2jniWTd91jW9a37mA1iuEwT4t8FpQOx+hWdlgRs6n0lo5HTm90JWw+tVAg4mdLyXXvnuiCb7SLM1nsXRoie/CiT0wpLsYrk6eBbEgPIkeOYvNRMCVwI61w5otnY6bwDf5pIM8yKCcrSIgvshB2+3VsLp97atgI87R16de2Wfkvy5ddzf43SbbvZjTnWuHxqP08aV1YnoQghVZuAbrK5Ag0EUpvMVgEQALefiwIZ8bAfz8ga4Se666xo3+1bxXouBHEVs+SvVlV5x6/pcpw46R+lHz1HnLdXCdilN3Bny2RrmH2T4+lD1oS5 6KZo8xcWTr9feVtxmBy4MykihjLT2Zk8rKFzQePeggMfG04X+a3xTbPdOBNajCYBJfzrh/NoWELJjXAUtYCm8uM9Xajr0Bj0VvrvLQ3bX+4J1qHisuGlw5/7XYdl5EfYGhlomaabz+T1FvkcDO5HKDffdmd8x6mOszq1psj9X5F8ef2m/sV+SIFQ+GKhslqCiz1wQnXk45BELoDILiFKrO3Ms9DUk+sthEgY9eai/5uaM84Hb2rFBba0yGVSudc/8C8DIhYl0Dkt5tW7QB4TQw9A9fy5/E5/sI1gtEYuw0Lzr1hcEmTlD2drHTlrJWql7CUeNZfxn3r6+LDJR+51sgysQ1sk/EF90TJCJz19OB1tIDO//yK3KIep39RdkoZwj3uwAsw0/vpOCkELk8P843VT6hitA7rzQn4bNg9Ex50M5ZDJdxa2oXT2LiNuGdFq/1AKj6S83OdaKFff3gu1oocsnN+EChuHMHm5LgQWUuX9lbzJ/xXP0N5b2bvQRbS7EAUa8yhfzAL//pR78jMxkKus6Mk7BkAzKCPM8VdcfXV32HjhH4ygcvUflYl4A5h2mzm5KsfVYDpThNuaZo0BABEBAAGJBFsEGAEIACYCGwIWIQRrPJM3S7s/VXj7rEkcSXJNIp6TogUCY2lUWQUJFI/vAwIpwV0gBBkBCAAGBQJSm8xWAAoJEG9I09oFwtrbRx0P/AqBcDQVi/sbwq/yaCgW7b/k8yj/5Rk7brUv9TtDLysnZNrKohbJe6zUHJPfnWck4OeOngENICsCkKeh8SuWqQjRSa1HxEOzpVOVzNhdJF+GTP9SOduyOvmLH85txLdf5idvA5TT9LLp9BB5pRADX6eZbEsvhISWFz3g7FYRwFCMEklFWhePstx/oUVVmzVwGetlPVrW5V0VS7ivNcVzy7QmKbIGP4th9asJdsfeGGVbamyCYEKPrSy50lKy63spEy9Pu3VfNLr+aKhV0s040O7y5qY5/Uwig nirFeT68fKQPOegoQQVOi79K85tJyvEREWmWxTw2g9CWtp4S61YQEcEC/VRx1LBByNEnK4ruuXwbZGeRBO+CsBZ53PnNRb5MXU7VHAsC0aE7O5nHTE1cuMTSi/iJmmSmTZvbuhLrBOpIw/GpHigNBBy342wV7nmSsieTL3oOScuGjeSxCfkg8bkzTAHghDm6lhJNCnApaH/brR0tVSgmE9A70XLxTnHoYSCLoD95NFk+sjNCp2qCsmIQ+bB7RbhgdIVFdBwipvnuu22V/kaE0S8DPPV5YEz3Vg/tY+s/HzHB+R6ilML1z9ies/hMRYR8BOdDAmjrphRCvmG4bF6JHTl0UpOWirl0ijPEJZRUg4cKVrZ0JOBm6DOk/Zj25MXOZ2QrYLjY5DKCRAcSXJNIp6TolofD/9XGgv5LNoZxiNR57qBx5045QAlyTfc/YGKRznJeoPMKQPlkaGAXtXp6ph48Vw4U0KYsvb0x3KErKPcolrt7zBB1FSInV1RQIMYEa0N1mrv3bZYmvC7mfiWTLqueFM7Ewvfc12eRwH/88ibN8K1h9O/EacMQ3YmJIhHKBstZ/PXaMhfAhaFG/dyjvsrHSz1hPICq9d13Mchbsszj71CbgoWCybfMVwzZ+TC1lBp+kAAHEESbMNZbPM/kuwBGe7tCK/VzKFMM4/9S+X/r1/Dde9G9HTTYJKFNGS0v85r4JfiSDCpfZgTYOR29QMyZdSF7Nx8zxuQxS8Idl4E0eI/0fuVO+JpnTCxDaPfx0xtty/5+vbSbTscMp7vF8n6fCVsEzYHp7/g3Sz1yCc7RPB6ivZBVGO7BHSVteW7O4wCIDeBt2PZdoWH+yuPDX8ckFKUyOV7i8PVgNfIlz3kJJCH8icONWzarXjAPZGau9jOTrOeoBcMM/tEAZrHqyGo5luAIp97saBaZRpmSx+UcSx2GBK/2JeZOYSukNY88rNvWGxBtJ93tkQdZyJQsUg5/AvFOxfUoRIHR5 RYactnqEt/F9xve8HGwk4s98murZtppL1HxT5fshhEExoOdIOs+pouyVYjyar8iSaz6cgpXYIqETwr7HfzgcLGfdEAUgBEXQkrSA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 384a3233-cfd2-4d9e-8dd4-aa10cff7e9e3 X-Archives-Hash: ffc834f4c8fa26ff3071d9316cb098a7 On Fri, 2024-07-19 at 09:20 +0000, Zurab Kvachadze wrote: >=20 > I haven't even known of this OpenRC feature! As you explained it, the > removal of NGINX_{CONFIG,PID}FILE totally makes sense. Should I also add > '-g "pid ${pidfile};"' to command_args for your example with > 'nginx-internal' to work automatically without any conf.d tinkering? Yes I think so. The ability to specify the PID path inside of a config file is a misfeature IMO. The person starting the daemon (OpenRC, in this case) is the only one who needs to care about the PID file, and having it in a config file just means that you have to change it in two places if you ever do decide to change it. It's much simpler to ignore the conf file (with -g pid ...) and let the init script be the source of truth. Very rarely someone will complain that they tried to change the PID location in their config file and it didn't work... but if you think about it for a second, that wouldn't have worked anyway. > With nginx.eclass, the build flags now configure NGINX to store its > temporary files in /var/tmp/nginx. Yet, NGINX doesn't create it by > itself, but rather aborts its execution if /var/tmp/nginx doesn't exist. > This is why I added the 'checkpath' line. As for the configtest, it's > redundant. >=20 > When NGINX is executed, it checks the configuration, making it > unnecessary to check the same thing beforehand (the error reporting is > identical anyway). configtest just duplicates NGINX's work and this may > lead to twice the time to bring NGINX up, which may matter if large "geo > module bases" are used[1]. >=20 Ok, no problem. I understood the checkpath but was curious about the quality of the error message with checkconfig() vs start(). Thanks for working on this!