From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 66AB315817D for ; Sat, 8 Jun 2024 19:44:08 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1E8E02BC05A; Sat, 8 Jun 2024 19:44:05 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ABBDB2BC034 for ; Sat, 8 Jun 2024 19:44:04 +0000 (UTC) Message-ID: Date: Sat, 8 Jun 2024 22:43:58 +0300 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH 1/2] common-lisp-3.eclass: Support EAPI 8 To: gentoo-dev@lists.gentoo.org, =?UTF-8?Q?Ulrich_M=C3=BCller?= Cc: common-lisp@gentoo.org References: <20240608194034.7741-1-ulm@gentoo.org> From: Arthur Zamarin Content-Language: en-US In-Reply-To: <20240608194034.7741-1-ulm@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------doiJRBO9pC0BLH0Ff0Ca8m0A" X-Archives-Salt: 5eddc9e8-92e0-4999-b0e1-ba4ebb67c3bd X-Archives-Hash: 5c60acea091659ee15ccc51d617a1cbe This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------doiJRBO9pC0BLH0Ff0Ca8m0A Content-Type: multipart/mixed; boundary="------------rCsbcAllZazfBTB0jdXXh8QE"; protected-headers="v1" From: Arthur Zamarin To: gentoo-dev@lists.gentoo.org, =?UTF-8?Q?Ulrich_M=C3=BCller?= Cc: common-lisp@gentoo.org Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/2] common-lisp-3.eclass: Support EAPI 8 References: <20240608194034.7741-1-ulm@gentoo.org> In-Reply-To: <20240608194034.7741-1-ulm@gentoo.org> --------------rCsbcAllZazfBTB0jdXXh8QE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/06/2024 22.40, Ulrich M=C3=BCller wrote: > Minor stylistic changes. >=20 > Signed-off-by: Ulrich M=C3=BCller > --- > eclass/common-lisp-3.eclass | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/eclass/common-lisp-3.eclass b/eclass/common-lisp-3.eclass > index 26d31268a598..12c7221e41ce 100644 > --- a/eclass/common-lisp-3.eclass > +++ b/eclass/common-lisp-3.eclass > @@ -1,17 +1,17 @@ > -# Copyright 1999-2023 Gentoo Authors > +# Copyright 1999-2024 Gentoo Authors > # Distributed under the terms of the GNU General Public License v2 > =20 > # @ECLASS: common-lisp-3.eclass > # @MAINTAINER: > # Common Lisp project > -# @SUPPORTED_EAPIS: 6 7 > +# @SUPPORTED_EAPIS: 6 7 8 > # @BLURB: functions to support the installation of Common Lisp librari= es > # @DESCRIPTION: > # Since Common Lisp libraries share similar structure, this eclass aim= s > # to provide a simple way to write ebuilds with these characteristics.= > =20 > case ${EAPI} in > - 6|7) ;; > + 6|7|8) ;; > *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; > esac > =20 > @@ -121,7 +121,7 @@ common-lisp-install-sources() { > =20 > local fpredicate=3D$(common-lisp-get-fpredicate "${ftype}") > =20 > - for path in "${@}" ; do > + for path ; do > if [[ -f ${path} ]] ; then > common-lisp-install-one-source ${fpredicate} "${path}" "$(dirname "= ${path}")" > elif [[ -d ${path} ]] ; then > @@ -148,7 +148,7 @@ common-lisp-install-sources() { > # Installs ${1} asdf file in CLSOURCEROOT/CLPACKAGE and symlinks it in= > # CLSYSTEMROOT. > common-lisp-install-one-asdf() { > - [[ $# !=3D 1 ]] && die "${FUNCNAME[0]} must receive exactly one argum= ent" > + [[ $# =3D 1 ]] || die "${FUNCNAME[0]} must receive exactly one argume= nt" > =20 > # the suffix =C2=AB.asd=C2=BB is optional > local source=3D${1%.asd}.asd > @@ -168,7 +168,7 @@ common-lisp-install-asdf() { > =20 > [[ $# =3D 0 ]] && set - ${CLSYSTEMS} > [[ $# =3D 0 ]] && set - $(find . -type f -name \*.asd) > - for sys in "${@}" ; do > + for sys ; do > common-lisp-install-one-asdf ${sys} > done > } LGTM, thanks! --=20 Arthur Zamarin arthurzam@gentoo.org Gentoo Linux developer (Python, pkgcore stack, QA, Arch Teams, GURU) --------------rCsbcAllZazfBTB0jdXXh8QE-- --------------doiJRBO9pC0BLH0Ff0Ca8m0A Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmZktH4ACgkQAqCvUD0S BQQ+WQgAwJ2wXGpNYaD9/IQ+hRFMonAfCgPF9J7pkwOGyD23pTUd1HSOCvG5Bwtu rWLGjQMA+awc8x0wLZOthYB6UXYHpeYMFw4NkkB88t4CPiuOrKF7mbjjxtbEaqGf UEApCc2gjB0vQiAThrGD6+GaedNl0ofZS/WFCGealb/tf2DtUlXcyhL3dhiWCCbl hawv5MfpwDc0s9zm0mL5dYcyZMSiUNAn3wIPXyyOUU+GPQFGJVBc4uY1vfsKW/8D N8Cm4HKvTCh5lVzQh9Ib+BdulvAZlCFDVsA0svdmMWGaJX8b2ng1+lfl3w6R09xc HcYPgxdA3bmF7DOPSk7hbWOsrqbxPA== =zxKm -----END PGP SIGNATURE----- --------------doiJRBO9pC0BLH0Ff0Ca8m0A--