From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5253A138334 for ; Mon, 10 Sep 2018 21:17:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 68485E0C27; Mon, 10 Sep 2018 21:17:48 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1BE6DE0A9F for ; Mon, 10 Sep 2018 21:17:48 +0000 (UTC) Received: from [192.168.2.102] (dslb-002-200-185-218.002.200.pools.vodafone-ip.de [2.200.185.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: chithanh) by smtp.gentoo.org (Postfix) with ESMTPSA id 9362F335CFD for ; Mon, 10 Sep 2018 21:17:46 +0000 (UTC) Subject: Re: [gentoo-dev] Changing policy about -Werror To: gentoo-dev@lists.gentoo.org References: <20180909143221.21d784d02f51623e8c57c545@gentoo.org> <79F8E956-12C7-4C96-A029-106B785294B3@gentoo.org> <20180910141926.GE23555@gentoo.org> From: =?UTF-8?Q?Ch=c3=ad-Thanh_Christopher_Nguy=e1=bb=85n?= Openpgp: preference=signencrypt Message-ID: Date: Mon, 10 Sep 2018 23:18:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.9.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20180910141926.GE23555@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Archives-Salt: 111a03ed-f521-4228-8c37-5aa695479f71 X-Archives-Hash: 58388941c87a114b053fad75a22bc636 Fabian Groffen schrieb: > On 09-09-2018 11:22:41 -0400, Richard Yao wrote: >> -Werror has caught bugs that could have resulted in data loss in ZFS in the past thanks to it being built in userspace as part of zdb. So it is useful for integrity too, not just security (although arguably, integrity is part of security). > > This is a misconception, as jer already pointed out. Instead: > > -Werror has forced you to take notice of problems that could have > resulted in data loss in ZFS ... But in general it doesn't say when or how the problems became acute. Assuming that the warning isn't bogus, it could have been the code relying on undefined behavior, and the compiler changing the semantics of such behavior, and introducing an accompanying warning at the same time. Best regards, Chí-Thanh Christopher Nguyễn