Re: [gentoo-dev] [PATCH] cargo.eclass: Optimize crate unpacking

[Florian Schmaus <flow@gentoo.org>]

On 12/05/2024 20.21, Michał Górny wrote:
> On Sun, 2024-05-12 at 19:22 +0200, Florian Schmaus wrote:
>> On 12/05/2024 04.26, Michał Górny wrote:
>>> +	if [[ ${PKGBUMPING} != ${PVR} ]]; then
>>> +		pushd "${DISTDIR}" >/dev/null || die
>>> +
>>> +		ebegin "Unpacking crates"
>>> +		printf '%s\0' "${crates[@]}" |
>>> +			xargs -0 -P "$(makeopts_jobs)" -n 1 -- \
>>
>> Consider using get_makeopts_jobs instead of makeopts_jobs, as it
>> searches more variables for --jobs.
> 
> Whose bright idea was to add a second similarly named function that does
> roughly the same thing but apparently differently?  It can hardly get
> more confusing.

You are absolutely right, it sucks that we have two very similar methods.

You are invited to suggest how the situation can be improved. However, 
rambling without presenting alternatives is not helpful in any way.

Potentially, you will either discover that there is a reason why things 
are the way they are, or find a better solution.

- Flow