public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] perl-module.eclass: extend DIST_TEST="do" to cover make-based tests
@ 2023-10-14 23:00 matoro
  0 siblings, 0 replies; only message in thread
From: matoro @ 2023-10-14 23:00 UTC (permalink / raw)
  To: Gentoo Dev

For packages using make to run tests rather than Test::Harness,
DIST_TEST="do" is ineffective at disabling parallelization.  This forces
-j1 on these packages when set.

Bug: https://bugs.gentoo.org/909051
Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>
---
  eclass/perl-module.eclass | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
index 32cd603c7be5..7bb02abed8c5 100644
--- a/eclass/perl-module.eclass
+++ b/eclass/perl-module.eclass
@@ -335,6 +335,7 @@ perl-module_src_test() {

  	local my_test_control
  	local my_test_verbose
+	local my_test_makeopts

  	[[ -n "${DIST_TEST_OVERRIDE}" ]] && ewarn "DIST_TEST_OVERRIDE is set 
to ${DIST_TEST_OVERRIDE}"
  	my_test_control=${DIST_TEST_OVERRIDE:-${DIST_TEST:-do parallel}}
@@ -344,6 +345,10 @@ perl-module_src_test() {
  		return 0
  	fi

+	if has 'do' ${my_test_control} && ! has 'parallel' ${my_test_control} 
; then
+		my_test_makeopts="-j1"
+	fi
+
  	if has verbose ${my_test_control} ; then
  		my_test_verbose=1
  	else
@@ -383,7 +388,7 @@ perl-module_src_test() {
  	if [[ -f Build ]] ; then
  		./Build test verbose=${my_test_verbose} || die "test failed"
  	elif [[ -f Makefile ]] ; then
-		emake test TEST_VERBOSE=${my_test_verbose}
+		emake ${my_test_makeopts} test TEST_VERBOSE=${my_test_verbose}
  	fi
  }

-- 
2.42.0



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-14 23:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-14 23:00 [gentoo-dev] [PATCH] perl-module.eclass: extend DIST_TEST="do" to cover make-based tests matoro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox