public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Jonas Stein <jstein@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] rfc: Remove inherit eutils from font.eclass for EAPI=6
Date: Sat, 5 May 2018 21:52:13 +0200	[thread overview]
Message-ID: <eebda1c2-e8f8-652f-6781-798374732b91@gentoo.org> (raw)
In-Reply-To: <1518696430.13990.1.camel@gentoo.org>


[-- Attachment #1.1: Type: text/plain, Size: 1688 bytes --]

On 2018-02-15 13:07, Mart Raudsepp wrote:
> On Thu, 2018-02-15 at 08:46 +0100, Guilherme Amadio wrote:
>> Most of the above only use usex, and terminus-font uses einstalldocs
>> as well.
>> I think these should be pretty easy to fix to not use eutils, or
>> simply
>> add 'inherit eutils' for these ebuilds, then remove from the eclass.
>>
>> I can help with testing by reading ebuilds more carefully and
>> emerging
>> them after the change in font.eclass.
> 
> einstalldocs is part of EAPI-6 and inherit eutils isn't needed for that
> if it's EAPI-6. In fact, eutils doesn't define it for EAPI-6, only 0-5.
> 
> Same with usex, except that's builtin already in EAPI-5.

Thank you all for your ideas and contributions.

I have looked at all ebuilds which are EAPI=6 and depend on eutils,
and do not inherit it directly but rely on the eutils via fonts.eclass.
They are all fixed now.

All ebuilds, which inherit fonts.eclass and EAPI=6 will still work fine
now, if we drop inherit eutils from font.eclass for EAPI=6

My suggesion is:

diff --git a/eclass/font.eclass b/eclass/font.eclass
index 7214c99854a..e212004bc44 100644
--- a/eclass/font.eclass
+++ b/eclass/font.eclass
@@ -1,12 +1,11 @@
-# Copyright 1999-2015 Gentoo Foundation
+# Copyright 1999-2018 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2

 # @ECLASS: font.eclass
-# @MAINTAINER:
-# fonts@gentoo.org
+# @MAINTAINER: fonts@gentoo.org
 # @BLURB: Eclass to make font installation uniform

-inherit eutils
+[[ ${EAPI} == [012345] ]] && inherit eutils

 EXPORT_FUNCTIONS pkg_setup src_install pkg_postinst pkg_postrm

-- 
Best,
Jonas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

  reply	other threads:[~2018-05-05 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 22:43 [gentoo-dev] rfc: Remove inherit eutils from font.eclass for EAPI=6 Jonas Stein
2018-02-15  1:16 ` Mart Raudsepp
2018-02-15  7:46   ` Guilherme Amadio
2018-02-15 11:07     ` Jonas Stein
2018-02-15 12:07     ` Mart Raudsepp
2018-05-05 19:52       ` Jonas Stein [this message]
2018-02-15  6:42 ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eebda1c2-e8f8-652f-6781-798374732b91@gentoo.org \
    --to=jstein@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox