From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-86029-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 06597138334
	for <garchives@archives.gentoo.org>; Sun, 23 Sep 2018 19:33:44 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 62E3FE0872;
	Sun, 23 Sep 2018 19:33:39 +0000 (UTC)
Received: from avasout05.plus.net (avasout05.plus.net [84.93.230.250])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id ECD76E086E
	for <gentoo-dev@lists.gentoo.org>; Sun, 23 Sep 2018 19:33:38 +0000 (UTC)
Received: from [192.168.6.147] ([212.159.46.162])
	by smtp with ESMTP
	id 4A8LgeMYY05ij4A8NghNgb; Sun, 23 Sep 2018 20:33:37 +0100
X-CM-Score: 0.00
X-CNFS-Analysis: v=2.3 cv=QJJGuDDL c=1 sm=1 tr=0
 a=RuViaDnnNG9rfPLW4VJocg==:117 a=RuViaDnnNG9rfPLW4VJocg==:17
 a=13zjGPudsaEWiJwPRgMA:9 a=7mOBRU54AAAA:8 a=owiGy8azA6J2rcyAQcYA:9
 a=QEXdDO2ut3YA:10 a=gbuZ3yVci1wqVK2Jq2AA:9 a=ONNS8QRKHyMA:10
 a=wa9RWnbW_A1YIeRBVszw:22
Subject: Re: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7
To: gentoo-dev@lists.gentoo.org, Mike Gilbert <floppym@gentoo.org>
Cc: udev-bugs@gentoo.org
References: <20180923152017.26128-1-floppym@gentoo.org>
From: "M. J. Everitt" <m.j.everitt@iee.org>
Openpgp: id=BA266E0525CFAB101523351B4C30334F93C22371
Autocrypt: addr=m.j.everitt@iee.org; prefer-encrypt=mutual; keydata=
 xsFNBFngC8gBEAC8/nQZrVrr8v0kaD4OLw8UftKfPQFEMGY/rnFA81M9IvdyPP8/8u/+9AGc
 DEN3i/LRvW0KUBdKIngcUY/p1M/sJqBspMOBaoOLp6K53/2uxcGXw62TulQJU+7a37Jukv2r
 HNSyZzM6II0myConmJa8ja1HfsiVoqDrqNigBF+Sts1kqG4xg8YeyOl1Tk+LZwC+ukzzutE9
 pbpIL2snu5I6a6RNi9DtbB9FZKzkbXx8TlpMXrcorNryOLQHPRw6tir5Z8kpetiJgoEpKGBX
 botDOWLVW+s9XnwPzAFmL03gH+3reY+LfrQWQTDphfZIp75caZQUicQHpc1NUr+8bLr3n79A
 FCPY3CfWriGn17aqaaXDFfeYPJIlH8UmOXI41JqR47C5eYFbocA8A4k7cGVAdKJFWLy51165
 dt7qZyvUQc/olzrZOrvoiWXA8ELg7pqxxObM4kl0502IHz9kb6Lt712HvfjH5yAP8zTYpetn
 sCPR9aVVSQsRgluNrQFlKpVmUXbeBLjw05UBEunS6prDwXOyZdn7t03LSOlK2nBGM+gtxg8l
 /0Nb1saYMGGN8qtO4RLFRiRBc20kNz01cC89PKRIXYlW9dRZNH1zebIUCAg+S4hSmmV4uvaZ
 XRADb2G+ZZ2jj9cNTTnI+X1/a19S8XjBZ4z+9+Hty4nhoB6fawARAQABzSNNLiBKLiBFdmVy
 aXR0IDxtLmouZXZlcml0dEBpZWUub3JnPsLBgAQTAQgAKgIbAwUJA8JnAAULCQgHAwUVCgkI
 CwUWAgMBAAIeAQIXgAUCWeAgogIZAQAKCRBj58Z59NQx3awfD/4wMWDKcu0/s2KQhz5JUBfi
 v+PdY7xxJj77gPhHximyjWW8O1pu3H280HsL2751AuUyQ2JNWYUtbr8FIvk8dLBnjLmXQwu/
 JhkPyAoW/3UcpSCjGkwZ0B/amHs9/dC99Y9Fk1lYDqm1FEmSmqnXHFg7tgdKpMF5eV7B0moS
 ISL0IKSOCMPHE1u/0bSwUVXbzuqWOLbWRcqH819aVsZG+unrQf87R0RKG5rI7OEkdtCDO+8D
 KlOPqo1i+Un9YvzdktNymHJtoHGljIWLoo5QMciHH5JX+y7bGH1mHfmnsqFsHiPQFkun3/xV
 qk9hI0qvl1q5ykX/UVZMmXaMVwWcpiLz4pHnN92v9BxyAESKJkj9fh9CoR958nmoLzhmVzdf
 pXHBlI4E5uYaKeCPbGNHZX0WoHaStf0f/AkuLSQj3g53VDWvDBt+qfnzBkGwYSGhM6tOQX5T
 Cz0WP8cZa6ghyzTy+z4jwT8/O9umurExdRl2D0VNdT4RPoCFs/jlFXFbnlGPC2FjvWfMEF8j
 9FiPq19NPPRd8WiQYgRYehFFoDqNOzIu3LbshV2CPdVN5fsRD1lwOGlrmiPWQrWlfKoUK98G
 M5MfAcSJVkixsfoajZlH5lk48kBQsMnLxut2pmRiahtsEV0af+FHLs1ZuYngk0kJh5q+UyZi
 4exXsLvHC/rPbs7BTQRZ4AvIARAA2MeaJF9ma6ngqTogwle2dHfAzilYpWSgt7Gej9APzidO
 mVfyoXIBsd3UMNQErFkRZNk/U0vyy0x9Azs3z0gqOo5E98veiN3VOf8g9vhTfxfHcVTz6JwX
 9ggzO//iRPvUH3NKfEvpLNn8gkOvN9cTyh0k9Vrj28vBpD3HWWHJlU5wVrpFUpE4RFXDOpMD
 aAQAPkArzxXmc6CtnQfupkpZPe+mplDoEjFmw1F6fLp/09a+K0m97xZU0eG/tYWqItRpTHnY
 8d92wFHNx1RdYyII8y2kCDNwp+E6oEX/DP5WspKGzgf/f9zci61v192wpXiqzoE9D+quFo9v
 z6Ywn8NCfqOUs+dnwZ9xtQXOHBU5lZi0avkg3HYQ1lArSkUHzlO4k5AslEu5AXqEOKe9Mo4q
 nYX/HK3xQEPwEJji2T8SR9IDPfAIYjSK6iMw7LT4ugCwVemNHmDSuWdZDjtbVMRdNtsWu0ar
 i04FQ+8cBovQHQyrVVYVduuazlBioX7dN8go17eue2C3hTr8xJhB4dX7/bfVAay1LeCWyaGr
 15nfkAH4wXp11sSU482GwRnEEL5TeYDgHHtd+FyiYm3Wd5T5NKgPM5XpzIhm4MvLmWMhmC4O
 nLc5gZj2aQ7IWi2W5FlxSSu0VrC0q6hoNB0rCsz1GBKDBrLX+03hZrMRC0TeZZ8AEQEAAcLB
 ZQQYAQgADwUCWeALyAIbDAUJA8JnAAAKCRBj58Z59NQx3cwiEACpDgKf6ZlEx27TWzoV73v/
 FV0Zy2vz+pqIIw2BKb1PbuEJnluZnWQ/u9nVCRoIQKDU5IHS+DoR76iTOUTiVmE+9ZltAHYi
 9QRAHlwWdFkZqkoTNvrHw7pA0oOhgqC3k1n3FpAbT8GFZeIKRqgWCacTMBepMJRlz46nQ/CX
 4Eh2HwrJrbgJJaMpNqoh+hJee7ev/TXV+OFLc310tJSZhSPXo9NkWGHu631RjOJl4Xf0vE4t
 Zy4aNE94NjMUOILjmaTp78HBUbsgqZrdl/wu2HbNNF5IKWwnyYRAeF9l73JuQwXLMrVQxbqP
 P9XiQqgKT4CF3xxdiXCS3Hq5s3OQLouFg03LGHyMAMtsP+8PepndmL/i79s/Mp0WYcJK6XAm
 Mi+Xknfi5Lay1oAjYu8UvGOWo5nOq62saN/bXG8/m+qqiueMOTDGXHZfklBglW5p6VYJd2eY
 W1teykJa7oGAOsiePl+z4UllNTBQVzhRPfmc/O3Yg6JJbISqHw84IWDINVUAN6wldIay83Tr
 gc1aAXDepgf6aNDbbWiQ+BBBJkAOGYTG9pnAaNMUKM65dkN7WufV2fwJHn900f2vzKyFYkKF
 bIiuODXBTfJG1yvMUQIgnDBYUBuBdDXB3NhOG8nHOJSQXTdI+Ma9ZMkxmVCxV9RXFPYBO8ji
 nurTf8FtGwnuig==
Message-ID: <ee4d0c65-3a51-4d99-2a39-f2347e634630@iee.org>
Date: Sun, 23 Sep 2018 20:33:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
In-Reply-To: <20180923152017.26128-1-floppym@gentoo.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qOzmOrZg9uvSfzkQQ1wLJ3uY1AuYqOxQv"
X-CMAE-Envelope: MS4wfH65HQXnllKB4bQUSgD4zxq2wBRko3nkBptAUHeKIfvBN3on47B+4He/AbCzXLuIpNX2mP+q5b+HIdLNyuzd4cUu7TKo0y7XPs7dflvxPqlaFC+GxSra
 a1hr+vIF9ZI1lGUWyWC1AQsEU+B5sCKOAy+AAGBGwXa4At2bFtRJUrbtyfwgp3cFWbBogDkxpEgrYg==
X-Archives-Salt: 5f28e417-74e6-4cbf-bf30-6b8f1c12e62c
X-Archives-Hash: d05dbd6d188e912cc1d9ad60add2f358

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qOzmOrZg9uvSfzkQQ1wLJ3uY1AuYqOxQv
Content-Type: multipart/mixed; boundary="ive33rQnYig35aS4hiLhFGb1qLNfC208z";
 protected-headers="v1"
From: "M. J. Everitt" <m.j.everitt@iee.org>
To: gentoo-dev@lists.gentoo.org, Mike Gilbert <floppym@gentoo.org>
Cc: udev-bugs@gentoo.org
Message-ID: <ee4d0c65-3a51-4d99-2a39-f2347e634630@iee.org>
Subject: Re: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7
References: <20180923152017.26128-1-floppym@gentoo.org>
In-Reply-To: <20180923152017.26128-1-floppym@gentoo.org>

--ive33rQnYig35aS4hiLhFGb1qLNfC208z
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB

On 23/09/18 16:20, Mike Gilbert wrote:
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
>  eclass/udev.eclass | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/eclass/udev.eclass b/eclass/udev.eclass
> index 4f23c9ebbdf8..baf60584938f 100644
> --- a/eclass/udev.eclass
> +++ b/eclass/udev.eclass
> @@ -1,10 +1,10 @@
> -# Copyright 1999-2014 Gentoo Foundation
> +# Copyright 1999-2018 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
> =20
>  # @ECLASS: udev.eclass
>  # @MAINTAINER:
>  # udev-bugs@gentoo.org
> -# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6
> +# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
>  # @BLURB: Default eclass for determining udev directories.
>  # @DESCRIPTION:
>  # Default eclass for determining udev directories.
> @@ -34,12 +34,16 @@ _UDEV_ECLASS=3D1
>  inherit toolchain-funcs
> =20
>  case ${EAPI:-0} in
> -	0|1|2|3|4|5|6) ;;
> +	0|1|2|3|4|5|6|7) ;;
>  	*) die "${ECLASS}.eclass API in EAPI ${EAPI} not yet established."
>  esac
> =20
> -RDEPEND=3D""
> -DEPEND=3D"virtual/pkgconfig"
> +if [[ ${EAPI:-0} =3D=3D [0123456] ]]; then
> +	RDEPEND=3D""
> +	DEPEND=3D"virtual/pkgconfig"
> +else
> +	BDEPEND=3D"virtual/pkgconfig"
> +fi
> =20
>  # @FUNCTION: _udev_get_udevdir
>  # @INTERNAL
Hate to nit-pick, but this *is* Gentoo .. the last IF, if EAPI <> 7 then
BDEPEND could also be dragged in, probably better to explicitly mention '=
7'.
Cheers,
Michael.
Replying off-list due to black-listing.


--ive33rQnYig35aS4hiLhFGb1qLNfC208z--

--qOzmOrZg9uvSfzkQQ1wLJ3uY1AuYqOxQv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJbp+qNAAoJEGPnxnn01DHdor8P/RRH3aSoQ17OaVkRTs1ZOXel
Sp6nFLjlKgzHSZgKqzUdW9B46gJCJygFohf/28Xpjx1X+RXfSmJf7CFSOCeyNUqA
qsrkBDx47k4CmWNJosDvS9Xie+GivtY+wF0eTFJK0sVcxOuMtbxQHHYgdO6qiK1r
d4fbBI8LGvsxwlH1EH6ucgGR2snkP2Kt3z+LxZ8385h1o3MDjE/gCW0nhAZXdLm8
VRrGrHjk8U/in1OV8CSZaTmDiNgjITdvkU64npHvyVWJoDkA6gP1Z30ynhY3n38w
gMClWITB4uwXlxO8FTHb6or8ajutQI3U4tsWxah1QOL4igfx75cHcua7zrA5F4xf
wsOvKiAGHSeAf9dU7KlVV3rs0P600GNFLJf+Hd1g/b8TvVf6/ta1HF3MNfMtGfuW
k5qd7RKB90Ngd+J2QZQ8FRJEpS29kAzC7+mKOc0iOKAjJfKGbqDwq2aSSVktrr9I
LhRdXk75sP8AqyZn/alpW9uI+YVA4sO1LMD6+Obhx4LpPYfT/TFJaf0vfV/0e4xi
Ig7fPSKioTMzdop/iqRlvoy7G5KmnKiGmEsZrvutW7wnLCAzwgaDzps1lc9xdTat
f9cw19lpfnjhKyspIW/IxWFPqdqS38mOQRxdbJhw6tW4lLVy1RXXwhr5tDNoy51j
va24RvOoh6cxP6fpuk5R
=Prwh
-----END PGP SIGNATURE-----

--qOzmOrZg9uvSfzkQQ1wLJ3uY1AuYqOxQv--