From: "M. J. Everitt" <m.j.everitt@iee.org>
To: gentoo-dev@lists.gentoo.org, Mike Gilbert <floppym@gentoo.org>
Cc: udev-bugs@gentoo.org
Subject: Re: [gentoo-dev] [PATCH] udev.eclass: support EAPI 7
Date: Sun, 23 Sep 2018 20:33:29 +0100 [thread overview]
Message-ID: <ee4d0c65-3a51-4d99-2a39-f2347e634630@iee.org> (raw)
In-Reply-To: <20180923152017.26128-1-floppym@gentoo.org>
[-- Attachment #1.1: Type: text/plain, Size: 1507 bytes --]
On 23/09/18 16:20, Mike Gilbert wrote:
> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
> ---
> eclass/udev.eclass | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/eclass/udev.eclass b/eclass/udev.eclass
> index 4f23c9ebbdf8..baf60584938f 100644
> --- a/eclass/udev.eclass
> +++ b/eclass/udev.eclass
> @@ -1,10 +1,10 @@
> -# Copyright 1999-2014 Gentoo Foundation
> +# Copyright 1999-2018 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: udev.eclass
> # @MAINTAINER:
> # udev-bugs@gentoo.org
> -# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6
> +# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
> # @BLURB: Default eclass for determining udev directories.
> # @DESCRIPTION:
> # Default eclass for determining udev directories.
> @@ -34,12 +34,16 @@ _UDEV_ECLASS=1
> inherit toolchain-funcs
>
> case ${EAPI:-0} in
> - 0|1|2|3|4|5|6) ;;
> + 0|1|2|3|4|5|6|7) ;;
> *) die "${ECLASS}.eclass API in EAPI ${EAPI} not yet established."
> esac
>
> -RDEPEND=""
> -DEPEND="virtual/pkgconfig"
> +if [[ ${EAPI:-0} == [0123456] ]]; then
> + RDEPEND=""
> + DEPEND="virtual/pkgconfig"
> +else
> + BDEPEND="virtual/pkgconfig"
> +fi
>
> # @FUNCTION: _udev_get_udevdir
> # @INTERNAL
Hate to nit-pick, but this *is* Gentoo .. the last IF, if EAPI <> 7 then
BDEPEND could also be dragged in, probably better to explicitly mention '7'.
Cheers,
Michael.
Replying off-list due to black-listing.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2018-09-23 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 15:20 [gentoo-dev] [PATCH] udev.eclass: support EAPI 7 Mike Gilbert
2018-09-23 19:33 ` M. J. Everitt [this message]
2018-09-24 0:45 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4d0c65-3a51-4d99-2a39-f2347e634630@iee.org \
--to=m.j.everitt@iee.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=udev-bugs@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox