From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B24D2139694 for ; Thu, 23 Mar 2017 16:36:43 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 23ADF21C1BF; Thu, 23 Mar 2017 16:36:31 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CF97C21C182 for ; Thu, 23 Mar 2017 16:36:30 +0000 (UTC) Received: from [192.168.1.100] (c-98-218-46-55.hsd1.md.comcast.net [98.218.46.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mjo) by smtp.gentoo.org (Postfix) with ESMTPSA id E44F134164C for ; Thu, 23 Mar 2017 16:36:29 +0000 (UTC) Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 To: gentoo-dev@lists.gentoo.org References: <20170316093806.31977-1-mgorny@gentoo.org> <1652433.oqbzW57v8l@porto> <20170323105101.0f622f66@gentoo.org> <3173924.ULbGtHHRMq@porto> <20170323143659.3c882568@gentoo.org> From: Michael Orlitzky Message-ID: Date: Thu, 23 Mar 2017 12:36:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20170323143659.3c882568@gentoo.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 9577c6bf-420b-4726-8ed0-154a5e220459 X-Archives-Hash: dd564371d61bcde1327bca2361ed84bb On 03/23/2017 09:36 AM, Alexis Ballier wrote: >> >> No, the argument is about "we want to clean up the tree from abusive >> hacks". > > This is yours. Mike's answer is merely asking for proper justification > and doesn't seem to have had an answer yet. > The PMS[0] says Ebuilds must not access [FILESDIR] in global scope. But, for example, autoconf-2.69-r2.ebuild does, if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then source "${FILESDIR}"/eblits/main.eblit || die fi in global scope. I think there are some related patches to block this sort of thing in portage, but portage can't be improved while a critical package is doing the thing that we want to prevent. [0] https://dev.gentoo.org/~ulm/pms/head/pms.html#fn4x12