From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH] check-reqs.eclass: more disk checks
Date: Tue, 20 Feb 2024 07:16:09 +0100 [thread overview]
Message-ID: <e8ce722583f3d9f418624dc04e45d87674829489.camel@gentoo.org> (raw)
In-Reply-To: <robbat2-20240219T221227-879316530Z@orbis-terrarum.net>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Mon, 2024-02-19 at 22:14 +0000, Robin H. Johnson wrote:
> On Mon, Feb 19, 2024 at 02:08:32PM -0800, Robin H. Johnson wrote:
> > Allow checking more disk space, for users with many split volumes and
> > ever-larger packages.
> >
> > gentoo-kernel-bin:
> > / >=350MB/version (in /lib/modules)
> > /boot >=40MB/version
> >
> > rust-bin:
> > /opt >=450MB/version
> Meta:
> Is this the time where we should rethink the CHECKREQS syntax?
>
> CHECKREQS_DISK="/:2G /opt/random:1G /usr:1G" etc?
> If we need to support paths with space, newline or array here.
>
Precisely what I wanted to say. Instead of adding more variables, let's
add an array and mark the existing vars as legacy.
CHECKREQ_DISK=(
/opt:...
/usr:...
)
However, Andrew's comment poses a bigger problem here.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2024-02-20 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 22:08 [gentoo-dev] [PATCH] check-reqs.eclass: more disk checks Robin H. Johnson
2024-02-19 22:14 ` [gentoo-dev] " Robin H. Johnson
2024-02-20 6:16 ` Michał Górny [this message]
2024-02-20 4:38 ` [gentoo-dev] " Sam James
2024-02-20 5:53 ` Andrew Ammerlaan
2024-02-26 6:31 ` [gentoo-dev] [PATCH v2 1/2] check-reqs.eclass: runtime disk checks for any path Robin H. Johnson
2024-02-26 7:01 ` zzam
2024-02-26 9:46 ` Robin H. Johnson
2024-02-26 13:50 ` Michał Górny
2024-02-26 6:31 ` [gentoo-dev] [PATCH v2 2/2] sys-firmware/intel-microcode: check-reqs for /boot space Robin H. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ce722583f3d9f418624dc04e45d87674829489.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox