From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-38977-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1NR6ah-0003RZ-4e
	for garchives@archives.gentoo.org; Sat, 02 Jan 2010 16:12:35 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 88C5DE0794;
	Sat,  2 Jan 2010 16:12:08 +0000 (UTC)
Received: from mail-fx0-f228.google.com (mail-fx0-f228.google.com [209.85.220.228])
	by pigeon.gentoo.org (Postfix) with ESMTP id 454A0E0794
	for <gentoo-dev@lists.gentoo.org>; Sat,  2 Jan 2010 16:12:08 +0000 (UTC)
Received: by fxm28 with SMTP id 28so5177217fxm.26
        for <gentoo-dev@lists.gentoo.org>; Sat, 02 Jan 2010 08:12:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:sender:received:in-reply-to
         :references:date:x-google-sender-auth:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        bh=/142ovo6hDfiI8+cBrQLp9nswo+MwCxY9q2enQlq8bU=;
        b=oBJIdyxo+6f57y6KUtu7IqtDMQV/03fKWqZfFast8pwE2QoOoP4RjCrzr2ruJpjooG
         +vGWW75YbYOi93Y4/TPxsRvu7rkIWtqzyRNDXo0vzw8ML/cms1Um5HpItUzttcf6zZ9N
         web9v9g+Fy376vVGi81uwExdPwXeLrctx4A1M=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=EVuTlvp/UeKczK7524hwYsG5PVopSd+8zNc2/6lrYIPzh2liFU6J1wSs+RES6J9pCm
         ion1sbGnO7QnCBphO3UIgMFbz9TYPe+KV3VEIHbOM1S+ehj8I+RuhMj5DHywNbbjitUF
         QyhMksjnok+1XgKeJ6XbY5clj/4Ob+FzSR53o=
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Sender: yngwin.gentoo@gmail.com
Received: by 10.239.156.193 with SMTP id n1mr2445518hbc.187.1262448726061; 
	Sat, 02 Jan 2010 08:12:06 -0800 (PST)
In-Reply-To: <4B3F6BB5.1030703@gentoo.org>
References: <4B3F6BB5.1030703@gentoo.org>
Date: Sat, 2 Jan 2010 17:12:05 +0100
X-Google-Sender-Auth: 5931f82d937f67de
Message-ID: <e117dbb91001020812o72dbf6cex69b65502ea66e901@mail.gmail.com>
Subject: Re: [gentoo-dev] [RFC] base.eclass
From: Ben de Groot <yngwin@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: 5c7f4883-7b46-459f-a33b-a962eac5066e
X-Archives-Hash: a2f66d013a607a6bc057cd6332e007f4

2010/1/2 Tom=C3=A1=C5=A1 Chv=C3=A1tal <scarabeus@gentoo.org>:
> Hola,
> I have incorporated all fixes to base.eclass that has been itching me
> for a while (closes both open bugs).
>
> Whats new:
> * base_src_install docs
> this thingie install docs and html_docs from bash array defined in
> global scope (or anywhere else indeed :P)
>
> * all bash variable arrays including the PATCHES one have support for
> folders
>
> * using same codestyle everywhere...
>
> * using pushd/popd instead of cd
>
> Diff and full eclass attached.

I support this.

Also, I would recommend using [[ instead of [ for tests throughout. It
is safer and better coding practice.
( See http://mywiki.wooledge.org/BashGuide/Practices/BashTests )

Cheers,
--=20
Ben de Groot
Gentoo Linux developer (qt, media, lxde, desktop-misc)
______________________________________________________