From: Ben de Groot <yngwin@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] base.eclass
Date: Sat, 2 Jan 2010 17:12:05 +0100 [thread overview]
Message-ID: <e117dbb91001020812o72dbf6cex69b65502ea66e901@mail.gmail.com> (raw)
In-Reply-To: <4B3F6BB5.1030703@gentoo.org>
2010/1/2 Tomáš Chvátal <scarabeus@gentoo.org>:
> Hola,
> I have incorporated all fixes to base.eclass that has been itching me
> for a while (closes both open bugs).
>
> Whats new:
> * base_src_install docs
> this thingie install docs and html_docs from bash array defined in
> global scope (or anywhere else indeed :P)
>
> * all bash variable arrays including the PATCHES one have support for
> folders
>
> * using same codestyle everywhere...
>
> * using pushd/popd instead of cd
>
> Diff and full eclass attached.
I support this.
Also, I would recommend using [[ instead of [ for tests throughout. It
is safer and better coding practice.
( See http://mywiki.wooledge.org/BashGuide/Practices/BashTests )
Cheers,
--
Ben de Groot
Gentoo Linux developer (qt, media, lxde, desktop-misc)
______________________________________________________
next prev parent reply other threads:[~2010-01-02 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 15:52 [gentoo-dev] [RFC] base.eclass Tomáš Chvátal
2010-01-02 16:12 ` Ben de Groot [this message]
2010-01-02 16:31 ` Tomáš Chvátal
2010-01-03 0:56 ` [gentoo-dev] " Mark Bateman
2010-01-03 1:56 ` Tomáš Chvátal
2010-01-03 6:23 ` Harald van Dijk
2010-01-03 10:28 ` Ulrich Mueller
2010-01-03 11:00 ` Harald van Dijk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e117dbb91001020812o72dbf6cex69b65502ea66e901@mail.gmail.com \
--to=yngwin@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox