From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B3F9C158064 for ; Thu, 2 May 2024 20:48:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6BDEFE29D0; Thu, 2 May 2024 20:48:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D1CF1E29B8; Thu, 2 May 2024 20:48:39 +0000 (UTC) Message-ID: Date: Thu, 2 May 2024 15:48:36 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs To: =?UTF-8?B?TWljaGFsIFByw612b3puw61r?= References: Content-Language: en-US Cc: gentoo-dev@lists.gentoo.org, gentoo-releng@lists.gentoo.org From: Ben Kohler In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Archives-Salt: e84bd138-e550-48f5-8a4e-f7f8f9f49ccf X-Archives-Hash: 7386df45868004815651c778683e8cd5 On 5/2/24 06:15, Michal Prívozník wrote: > Hi, > > I've noticed (thanks to an issue reported against Libvirt [1]), that > neither minimal installation ISO nor liveGUI ISO contain anything inside > their Primary Volume Descriptors that would hint the ISO contains > Gentoo. This is unfortunate a bit, because matching VolumeID is exactly > how tools like libosinfo detect distro on given ISO [2] and then can > recommend some values when creating VMs with that ISO. In this specific > case, minimal amount of memory required to even boot the ISO (yeah, it > currently reports 256MiB which is too small for anything really). > > Is there any chance this could be fixed, e.g. by reporting something in > VolumeID? > > Michal > > 1: https://gitlab.com/libvirt/libvirt/-/issues/600 > 2: https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/gentoo.org/gentoo-rolling.xml.in?ref_type=heads > > Hi Michal, Thanks for bringing this to our attention.  Relatively recently, our ISO build tool catalyst started using grub-mkrescue to prepare the bootloaders and create the iso [1], and we seem to have lost the volume IDs at that time.  I've just added a -volid parameter back in [2] which should restore the volume IDs we were using before and should match what libosinfo is expecting.  The change should apply to our next weekly autobuilds. Before: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM filesystem data (DOS/MBR boot sector) 'ISOIMAGE' (bootable) After: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM filesystem data (DOS/MBR boot sector) 'Gentoo x86 20240429T170419Z' (bootable) [1] https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=0a27a7a39a7d6944618009f8027fb09a22244c34 [2] https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=04c70a9df505718c7e97ca1484f7c03270e6824c