public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ben Kohler <bkohler@gentoo.org>
To: "Michal Prívozník" <mprivozn@redhat.com>
Cc: gentoo-dev@lists.gentoo.org, gentoo-releng@lists.gentoo.org
Subject: Re: [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs
Date: Thu, 2 May 2024 15:48:36 -0500	[thread overview]
Message-ID: <dd4e63eb-8fc8-4bb4-9a34-6a7dfa898913@gentoo.org> (raw)
In-Reply-To: <b0c4c93e-4775-478e-a1c2-110c237740c1@redhat.com>


On 5/2/24 06:15, Michal Prívozník wrote:
> Hi,
>
> I've noticed (thanks to an issue reported against Libvirt [1]), that
> neither minimal installation ISO nor liveGUI ISO contain anything inside
> their Primary Volume Descriptors that would hint the ISO contains
> Gentoo. This is unfortunate a bit, because matching VolumeID is exactly
> how tools like libosinfo detect distro on given ISO [2] and then can
> recommend some values when creating VMs with that ISO. In this specific
> case, minimal amount of memory required to even boot the ISO (yeah, it
> currently reports 256MiB which is too small for anything really).
>
> Is there any chance this could be fixed, e.g. by reporting something in
> VolumeID?
>
> Michal
>
> 1: https://gitlab.com/libvirt/libvirt/-/issues/600
> 2: https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/gentoo.org/gentoo-rolling.xml.in?ref_type=heads
>
>
Hi Michal,

Thanks for bringing this to our attention.  Relatively recently, our ISO 
build tool catalyst started using grub-mkrescue to prepare the 
bootloaders and create the iso [1], and we seem to have lost the volume 
IDs at that time.  I've just added a -volid parameter back in [2] which 
should restore the volume IDs we were using before and should match what 
libosinfo is expecting.  The change should apply to our next weekly 
autobuilds.

Before: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM 
filesystem data (DOS/MBR boot sector) 'ISOIMAGE' (bootable)

After: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM 
filesystem data (DOS/MBR boot sector) 'Gentoo x86 20240429T170419Z' 
(bootable)

[1] 
https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=0a27a7a39a7d6944618009f8027fb09a22244c34

[2] 
https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=04c70a9df505718c7e97ca1484f7c03270e6824c



  reply	other threads:[~2024-05-02 20:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 11:15 [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs Michal Prívozník
2024-05-02 20:48 ` Ben Kohler [this message]
2024-05-03  8:43   ` Michal Prívozník
2024-05-03 11:32     ` Eli Schwartz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd4e63eb-8fc8-4bb4-9a34-6a7dfa898913@gentoo.org \
    --to=bkohler@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=gentoo-releng@lists.gentoo.org \
    --cc=mprivozn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox