public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Michael Orlitzky <mjo@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: die explicitly if HOME is missing in preinst
Date: Thu, 15 Aug 2019 15:01:13 -0400	[thread overview]
Message-ID: <dcd541f7-4674-08f2-ce58-7d78a68fd540@gentoo.org> (raw)
In-Reply-To: <20190815154355.1086130-1-floppym@gentoo.org>

On 8/15/19 11:43 AM, Mike Gilbert wrote:
> 
> +		# Path might be missing due to INSTALL_MASK, etc.
> +		# https://bugs.gentoo.org/691478
> +		if [[ ! -e "${ED}/${ACCT_USER_HOME#/}" ]]; then
> +			eerror "Home directory is missing from the installation image:"
> +			eerror "  ${ACCT_USER_HOME}"
> +			eerror "Check INSTALL_MASK for entries that would cause this."
> +			die "${ACCT_USER_HOME} does not exist"
> +		fi

This suggests that the problem is with the user's INSTALL_MASK, and not
with the package that crashed. I would rather they file a bug than
change their mask entry. But, I guess it's pretty easy these days to
grep the whole acct-user category for issues like this that I missed on
the mailing list.


  parent reply	other threads:[~2019-08-15 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 15:43 [gentoo-dev] [PATCH] acct-user.eclass: die explicitly if HOME is missing in preinst Mike Gilbert
2019-08-15 16:02 ` Michał Górny
2019-08-15 19:01 ` Michael Orlitzky [this message]
2019-08-15 21:12   ` Mike Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd541f7-4674-08f2-ce58-7d78a68fd540@gentoo.org \
    --to=mjo@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox