Re: [gentoo-dev] [PATCH 2/3] [QA] allow overriding settings

[Eli Schwartz <eschwartz93@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1726 bytes --]

On 5/5/24 11:48 AM, Paul Zander wrote:
> Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
> ---
>  .editorconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/.editorconfig b/.editorconfig
> index f2cd7328e57..dc1d5587a8b 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -2,7 +2,6 @@
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # https://editorconfig.org/
> -root = true

Can you explain the goal of this better? Removing this setting tells
editorconfig that the gentoo.git repo is a subdirectory of a wider
project scope, and that it should check e.g. /var/db/repos/.editorconfig
and /var/db/.editorconfig and /var/.editorconfig as well -- and in the
event of two files trying to set the same editorconfig setting, the file
you're editing in this patch wins.

So this will not actually allow one to override settings, for two reasons:

- it imposes an awkward UX requirement that the way to override settings
  is to move your gentoo.git clone into a subdirectory of a dedicated
  directory existing solely to provide its own .editorconfig file along
  with the gentoo/ (clone) directory

- it does exactly the opposite of overriding settings, because it allows
  you to set non-overriding defaults

and it also requires editorconfig tooling to walk every directory upward
until it reaches the / directory to check for more files, which is a
pointless waste. The editorconfig standard *specifically* expects you to
set root=true at the top level scope of your project, and this patch is
in opposition to the recommended workflow.

What workflow are you envisioning people will use if this patch is merged?

-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]