From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5082B15802E for ; Sun, 30 Jun 2024 19:18:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5D1C52BC015; Sun, 30 Jun 2024 19:18:54 +0000 (UTC) Received: from forward502a.mail.yandex.net (forward502a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d502]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E8B78E2B5E for ; Sun, 30 Jun 2024 19:18:53 +0000 (UTC) Received: from mail-nwsmtp-smtp-production-main-46.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-46.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:6012:0:640:b98d:0]) by forward502a.mail.yandex.net (Yandex) with ESMTPS id 8D66F60B83 for ; Sun, 30 Jun 2024 22:18:49 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-46.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id kIaoq4BTiW20-GXdybl4O; Sun, 30 Jun 2024 22:18:48 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail; t=1719775129; bh=hYQv6AKRVfhNqwAzKQdEO5Wqx6cy2/hFOKWNg3+TrJg=; h=In-Reply-To:From:Date:References:To:Subject:Message-ID; b=QAmYI/emxig1SrwOxF4RMUQsyQ0DZnX+vB3f1T+rDVZmj8gj8HkMRRxe3hvtEAOl0 7ffwYzT84IVzg7X6wKzZIqQsKfu9SpWTA8T97GDsEfNw2HJQxlC7Xw+qqJwQneYOu0 qGpF43zC/EPKm6sCAcZ4HurjoCSnVgXPjNWPHqrI= Authentication-Results: mail-nwsmtp-smtp-production-main-46.myt.yp-c.yandex.net; dkim=pass header.i=@ya.ru Message-ID: Date: Sun, 30 Jun 2024 23:18:46 +0400 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] Reviewing ebuilds with git To: gentoo-dev@lists.gentoo.org References: <87r0cepbzs.fsf@gentoo.org> Content-Language: en-US From: Vitaly Zdanevich In-Reply-To: <87r0cepbzs.fsf@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 35254737-8491-4239-b06f-de1b985de8a0 X-Archives-Hash: 4762c52f2f3a62c04866ba89c0a5e468 Should this patch be added to git ebuild patch folder, with a new USE flag? On 6/30/24 21:38, Sam James wrote: > Hi, > > I've mentioned this on IRC a bunch of times to people but I figure I'll > mention it here in case anyone finds it useful. > > Our use of git doesn't lend itself well to the default mode `git diff` > and friends operate in, as we create many new files rather than solely > changing existing ones. > > git can be coerced into checking for copies (and doing so "harder" too) > but there's no configuration option for this, and it's a pain to > remember. > > You can use the attached patch for dev-vcs/git and then set: > $ git config diff.renames copies-harder > in gentoo.git to make `git log -p`, `git diff`, etc default to this > mode. > > IME, it makes reviewing much easier. Be warned that it does make git log > a bit slower though if the config option is enabled for a repo -- but > maybe only noticeably if your repo is grafted with the pre-2015 CVS history. > > > thanks, > sam >