public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Piotr Jaroszyński" <peper@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] GLEP 54 and hyphens in PV
Date: Thu, 28 May 2009 17:55:16 +0200	[thread overview]
Message-ID: <d77765540905280855m5158722aqeed6a3842fca7311@mail.gmail.com> (raw)
In-Reply-To: <4A1EAA0D.9010500@gentoo.org>

2009/5/28 Marijn Schouten (hkBst) <hkBst@gentoo.org>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Piotr Jaroszyński wrote:
>> 2009/5/28 Ulrich Mueller <ulm@gentoo.org>:
>>>>>>>> On Thu, 28 May 2009, Tiziano Müller wrote:
>>>>> ${PORTDIR}/app-misc/foo/foo-1a_live.ebuild
>>>>> ${PORTDIR}/app-misc/foo-1a/foo-1a-live.ebuild
>>>> you probably mean:
>>>> ${PORTDIR}/app-misc/foo-1a/foo-1a.live.ebuild
>>> No, I mean what I had written, namely to use an underscore as
>>> separator, i.e., "_live". But when the version is just "live" alone,
>>> one would suppress the underscore for aesthetic reasons, i.e. instead
>>> of "foo-1a-_live" it would be "foo-1a-live".
>>>
>>>> but how would their vdb or binpkg names be unique?
>>>> vdb for example:
>>>> app-misc/foo-1a_live for app-misc/foo
>>> PN=foo, PV=1a_live => app-misc/foo-1a_live
>>>
>>>> app-misc/foo-1a_live for app-misc/foo-1a
>>> PN=foo-1a, PV=live => app-misc/foo-1a-live
>>>
>>>> am I missing something?
>>> Everything is easy, if you keep the following rule in mind:
>>>
>>>>> With our current versioning scheme the rule is very simple: ${P} is
>>>>> split into ${PN} and ${PV} at the last hyphen. This can be done in
>>>>> a straight forward way by regexp matching, and I would really hate
>>>>> to lose this nice property.
>>>> I don't understand why this property is important. Can you please
>>>> explain?
>>> See above, it automatically avoids any ambiguities in splitting P into
>>> PN and PV. And look at function "pkgsplit" in Portage: It can just
>>> treat PV as an opaque string.
>>>
>>> What would be the advantage to use a hyphen instead of an underscore?
>>
>> Mainly the thing you observed yourself - foo_live is a bit
>> inconsistent with current versions.
>
> Ulrich is proposing foo-live if live is the entire version, foo_live is not a
> legal `package name and version'. (It could be a package name though.)

I know, it's also inconsistent. Anyway that's really not that
important. We could forbid package names that end with a -$PV where
$PV is a valid version spec. That would make package names like foo-1b
invalid (didn't see anything named like that in the tree anyway).

>> The case you mention can be avoided with another restriction in PMS.
>> Buut we might as well go all the way and change the version separator
>> to -- or something, which would be the most flexible.
>
> That would also be a good solution though we don't seem to need it yet. It would
> also entail compatibility issues.

Not with g55.

-- 
Best Regards,
Piotr Jaroszyński



  reply	other threads:[~2009-05-28 15:55 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17 15:56 [gentoo-dev] GLEP 55 updated Piotr Jaroszyński
2009-05-17 16:06 ` Peter Alfredsen
2009-05-17 17:24   ` Nirbheek Chauhan
2009-05-17 18:47     ` Peter Alfredsen
2009-05-17 16:20 ` Denis Dupeyron
2009-05-17 17:20   ` Ulrich Mueller
2009-05-17 17:39     ` Jorge Manuel B. S. Vicetto
2009-05-17 17:43       ` Markos Chandras
2009-05-17 17:44       ` Joe Peterson
2009-05-17 21:17       ` Ben de Groot
2009-05-17 21:20         ` Ciaran McCreesh
2009-05-17 22:04           ` Joe Peterson
2009-05-18 15:07             ` [gentoo-dev] " Steven J Long
2009-05-18 15:16               ` Ciaran McCreesh
2009-05-18 15:28                 ` versionator.eclass terminator, was " Jeroen Roovers
2009-05-18 15:33                   ` Ciaran McCreesh
2009-05-18 15:42                   ` Robert Buchholz
2009-05-18 15:45                     ` Ciaran McCreesh
2009-05-18 15:30                 ` Joe Peterson
2009-05-17 22:08           ` [gentoo-dev] " Ben de Groot
2009-05-17 22:11             ` Ciaran McCreesh
2009-05-17 22:54               ` Ulrich Mueller
2009-05-17 22:58                 ` Ciaran McCreesh
2009-05-17 23:11                   ` Ulrich Mueller
2009-05-17 23:16                     ` Ciaran McCreesh
2009-05-17 23:30                       ` Ulrich Mueller
2009-05-17 23:33                         ` Ciaran McCreesh
2009-05-17 23:43                           ` [gentoo-dev] GLEP 54 and hyphens in PV (was: GLEP 55 updated) Ulrich Mueller
2009-05-17 23:49                             ` Ciaran McCreesh
2009-05-18  4:59                               ` [gentoo-dev] GLEP 54 and hyphens in PV Ulrich Mueller
2009-05-18 14:13                                 ` Ciaran McCreesh
2009-05-19 17:01                                   ` Ulrich Mueller
2009-05-19 17:59                                     ` Joe Peterson
2009-05-19 19:01                                     ` Kent Fredric
2009-05-28  7:59                                     ` Tiziano Müller
2009-05-28 10:54                                       ` Ulrich Mueller
2009-05-28 11:10                                         ` Piotr Jaroszyński
2009-05-28 15:13                                           ` Marijn Schouten (hkBst)
2009-05-28 15:55                                             ` Piotr Jaroszyński [this message]
2009-05-17 22:15             ` [gentoo-dev] GLEP 55 updated David Leverton
2009-05-18 15:28               ` [gentoo-dev] " Steven J Long
2009-05-18 15:58                 ` David Leverton
2009-05-17 17:36   ` [gentoo-dev] " Joe Peterson
2009-05-17 18:15 ` [gentoo-dev] " Ryan Hill
2009-05-17 18:17   ` Piotr Jaroszyński
2009-05-17 18:18   ` Ciaran McCreesh
2009-05-17 18:59     ` Ryan Hill
2009-05-17 18:40 ` [gentoo-dev] " Thomas de Grenier de Latour
2009-05-17 18:47   ` Ciaran McCreesh
2009-05-17 19:57     ` Thomas de Grenier de Latour
2009-05-17 20:20       ` Ciaran McCreesh
2009-05-17 18:57 ` Robert Buchholz
2009-05-17 19:31   ` Arfrever Frehtes Taifersar Arahesis
2009-05-17 19:33   ` Piotr Jaroszyński
2009-05-17 19:25 ` [gentoo-dev] " Piotr Jaroszyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d77765540905280855m5158722aqeed6a3842fca7311@mail.gmail.com \
    --to=peper@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox