public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Eli Schwartz <eschwartz93@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] games-strategy/wargus: Fix running it with games-engines/stratagus[debug]
Date: Thu, 15 Feb 2024 07:59:40 -0500	[thread overview]
Message-ID: <d62c2616-8398-4e95-937b-7925a1a35559@gmail.com> (raw)
In-Reply-To: <20240215125325.19959-1-zzam@gentoo.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1467 bytes --]

On 2/15/24 7:53 AM, Matthias Schwarzott wrote:
> When stratagus is compiled with USE=debug, its executable is called
> /usr/bin/stratatgus-dbg.
> 
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> ---
>  games-strategy/wargus/wargus-3.3.2.ebuild | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/games-strategy/wargus/wargus-3.3.2.ebuild b/games-strategy/wargus/wargus-3.3.2.ebuild
> index fff6023fa177..3295b2911d48 100644
> --- a/games-strategy/wargus/wargus-3.3.2.ebuild
> +++ b/games-strategy/wargus/wargus-3.3.2.ebuild
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2024 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI=8
> @@ -46,10 +46,12 @@ pkg_pretend() {
>  }
>  
>  src_configure() {
> +	local suffix=
> +	has_version games-engines/stratagus[debug] && suffix=-dbg
>  	local mycmakeargs=(
>  		-DGAMEDIR="${EPREFIX}/usr/bin"
>  		-DBINDIR="${EPREFIX}/usr/bin"
> -		-DSTRATAGUS="${EPREFIX}/usr/bin/stratagus"
> +		-DSTRATAGUS="${EPREFIX}/usr/bin/stratagus${suffix}"
>  		-DSHAREDIR="${EPREFIX}/usr/share/stratagus/wargus"
>  		-DICONDIR=/usr/share/icons/hicolor/64x64/apps
>  		-DWITH_STORMLIB=$(usex bne)



Ok so this just means the package will be broken if you change the USE
flags for stratagus and wargus doesn't get rebuilt.

Why is the executable name different, anyway?


-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-02-15 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 12:53 [gentoo-dev] [PATCH] games-strategy/wargus: Fix running it with games-engines/stratagus[debug] Matthias Schwarzott
2024-02-15 12:59 ` Eli Schwartz [this message]
2024-02-15 13:21   ` zzam
2024-02-15 13:25     ` [gentoo-dev] [PATCH] games-engines/stratagus: Unbreak USE=debug case Matthias Schwarzott
2024-02-15 13:37     ` [gentoo-dev] [PATCH v2] " Matthias Schwarzott
2024-02-15 14:09     ` [gentoo-dev] [PATCH] games-strategy/wargus: Fix running it with games-engines/stratagus[debug] Michał Górny
2024-02-15 14:23       ` parona
2024-02-15 15:06         ` Michał Górny
2024-02-15 19:10           ` zzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d62c2616-8398-4e95-937b-7925a1a35559@gmail.com \
    --to=eschwartz93@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox