From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101828-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 1BA301581D3
	for <garchives@archives.gentoo.org>; Sun, 19 May 2024 09:07:06 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 1765CE2A12;
	Sun, 19 May 2024 09:07:01 +0000 (UTC)
Received: from km35626.keymachine.de (mail.text-idiomas.com [87.118.86.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id B1DF5E2A0E
	for <gentoo-dev@lists.gentoo.org>; Sun, 19 May 2024 09:06:59 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by km35626.keymachine.de (Postfix) with ESMTP id BCE31118094E
	for <gentoo-dev@lists.gentoo.org>; Sun, 19 May 2024 11:06:56 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at km35626.keymachine.de.
Received: from km35626.keymachine.de ([127.0.0.1])
	by localhost (km35626.keymachine.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NrGR0oQQJfPl for <gentoo-dev@lists.gentoo.org>;
	Sun, 19 May 2024 11:06:55 +0200 (CEST)
Received: from moto.dh.dhaller.de (tmo-066-165.customers.d1-online.com [80.187.66.165])
	by km35626.keymachine.de (Postfix) with ESMTPSA id 5B232113F1F9
	for <gentoo-dev@lists.gentoo.org>; Sun, 19 May 2024 11:06:55 +0200 (CEST)
Date: Sun, 19 May 2024 11:06:53 +0200 (GMT+02:00)
From: gentoo@dhaller.de
To: gentoo-dev@lists.gentoo.org
Message-ID: <d5757bf5-1e45-4a1e-8cc4-d44dc9aab399@dhaller.de>
In-Reply-To: <20240508171505.48392-2-flow@gentoo.org>
References: <20240508171505.48392-1-flow@gentoo.org> <20240508171505.48392-2-flow@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/2] edo.eclass: enhace edob for usage with
 nosiy commands
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Correlation-ID: <d5757bf5-1e45-4a1e-8cc4-d44dc9aab399@dhaller.de>
X-Archives-Salt: 20e7476c-add3-45db-a267-c43b8a0c7b72
X-Archives-Hash: 4e79208a252647752ba609dd023cc164

Hello,

08.05.2024 19:15:52 Florian Schmaus <flow@gentoo.org>:
[..]
> # @FUNCTION: edob
> -# @USAGE: <command> [<args>...]
> +# @USAGE: [-m <message>] [-l <log-name>] <command> [<args>...]
                             ^^!
[..]
> -l <log-name> is provided, then <log-name> is
[..]
> edob() {
[..]
> +   while true; do
> +       case "${1}" in
> +           -m|-n)
                 ^^! ITYM '-l' here

> +               [[ $# -lt 2 ]] && die "Must provide an argument to ${1}"
> +               case "${1}" in
> +                   -m)
> +                       message="${2}"
> +                       ;;
> +                   -n)
                      ^^! ITYM '-l' here

> +                       log="${2}"
>
[..]

Fix yer option character ;)

-dnh