public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: gentoo@dhaller.de
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] edo.eclass: enhace edob for usage with nosiy commands
Date: Sun, 19 May 2024 11:06:53 +0200 (GMT+02:00)	[thread overview]
Message-ID: <d5757bf5-1e45-4a1e-8cc4-d44dc9aab399@dhaller.de> (raw)
In-Reply-To: <20240508171505.48392-2-flow@gentoo.org>

Hello,

08.05.2024 19:15:52 Florian Schmaus <flow@gentoo.org>:
[..]
> # @FUNCTION: edob
> -# @USAGE: <command> [<args>...]
> +# @USAGE: [-m <message>] [-l <log-name>] <command> [<args>...]
                             ^^!
[..]
> -l <log-name> is provided, then <log-name> is
[..]
> edob() {
[..]
> +   while true; do
> +       case "${1}" in
> +           -m|-n)
                 ^^! ITYM '-l' here

> +               [[ $# -lt 2 ]] && die "Must provide an argument to ${1}"
> +               case "${1}" in
> +                   -m)
> +                       message="${2}"
> +                       ;;
> +                   -n)
                      ^^! ITYM '-l' here

> +                       log="${2}"
>
[..]

Fix yer option character ;)

-dnh


  reply	other threads:[~2024-05-19  9:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 17:15 [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands Florian Schmaus
2024-05-08 17:15 ` [gentoo-dev] [PATCH 1/2] " Florian Schmaus
2024-05-19  9:06   ` gentoo [this message]
2024-05-08 17:15 ` [gentoo-dev] [PATCH 2/2] eftmutil-sys: use edob Florian Schmaus
2024-05-13 15:05 ` [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5757bf5-1e45-4a1e-8cc4-d44dc9aab399@dhaller.de \
    --to=gentoo@dhaller.de \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox