From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 35298158451 for ; Wed, 10 Jan 2024 14:21:07 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2C2802BC036; Wed, 10 Jan 2024 14:21:03 +0000 (UTC) Received: from uriel.iewc.co.za (uriel.iewc.co.za [IPv6:2c0f:f720:0:3::9a49:2248]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 942312BC023 for ; Wed, 10 Jan 2024 14:21:01 +0000 (UTC) Received: from [154.73.32.4] (helo=tauri.local.uls.co.za) by uriel.iewc.co.za with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNZRy-0002y6-1G; Wed, 10 Jan 2024 16:20:58 +0200 Received: from [192.168.42.192] by tauri.local.uls.co.za with esmtp (Exim 4.96) (envelope-from ) id 1rNZRw-0001kP-2W; Wed, 10 Jan 2024 16:20:56 +0200 Content-Type: multipart/alternative; boundary="------------OXdyTE0cJKh7EzgpdvEPGGSs" Message-ID: Date: Wed, 10 Jan 2024 16:20:56 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] Last rites: app-admin/fluentd Content-Language: en-GB To: gentoo-dev@lists.gentoo.org, Sam James References: <2cbe001a5fbea17c3222ec09f4d6e2d6cfc7e36c.camel@gentoo.org> <4cf06ce7-545c-4d25-b179-ee0a33b11265@uls.co.za> <0ca39f35-86a3-4777-bf20-d5d36cdf68c6@uls.co.za> <87y1cxmovv.fsf@gentoo.org> From: Jaco Kroon Autocrypt: addr=jaco@uls.co.za; keydata= xsBNBFXtplYBCADM6RTLCOSPiclevkn/gdf8h9l+kKA6N+WGIIFuUtoc9Gaf8QhXWW/fvUq2 a3eo4ULVFT1jJ56Vfm4MssGA97NZtlOe3cg8QJMZZhsoN5wetG9SrJvT9Rlltwo5nFmXY3ZY gXsdwkpDr9Y5TqBizx7DGxMd/mrOfXeql57FWFeOc2GuJBnHPZQMJsQ66l2obPn36hWEtHYN gcUSPH3OOusSEGZg/oX/8WSDQ/b8xz1JKTEgcnu/JR0FxzjY19zSHmbnyVU+/gF3oeJFcEUk HvZu776LRVdcZ0lb1bHQB2K9rTZBVeZLitgAefPVH2uERVSO8EZO1I5M7afV0Kd/Vyn9ABEB AAHNG0phY28gS3Jvb24gPGphY29AdWxzLmNvLnphPsLAdwQTAQgAIQUCVe2mVgIbAwULCQgH AgYVCAkKCwIEFgIDAQIeAQIXgAAKCRAILcSxr/fungCPB/sHrfufpRbrVTtHUjpbY4bTQLQE bVrh4/yMiKprALRYy0nsMivl16Q/3rNWXJuQ0gR/faC3yNlDgtEoXx8noXOhva9GGHPGTaPT hhpcp/1E4C9Ghcaxw3MRapVnSKnSYL+zOOpkGwye2+fbqwCkCYCM7Vu6ws3+pMzJNFK/UOgW Tj8O5eBa3DiU4U26/jUHEIg74U+ypYPcj5qXG0xNXmmoDpZweW41Cfo6FMmgjQBTEGzo9e5R kjc7MH3+IyJvP4bzE5Paq0q0b5zZ8DUJFtT7pVb3FQTz1v3CutLlF1elFZzd9sZrg+mLA5PM o8PG9FLw9ZtTE314vgMWJ+TTYX0kzsBNBFXtplYBCADedX9HSSJozh4YIBT+PuLWCTJRLTLu jXU7HobdK1EljPAi1ahCUXJR+NHvpJLSq/N5rtL12ejJJ4EMMp2UUK0IHz4kx26FeAJuOQMe GEzoEkiiR15ufkApBCRssIj5B8OA/351Y9PFore5KJzQf1psrCnMSZoJ89KLfU7C5S+ooX9e re2aWgu5jqKgKDLa07/UVHyxDTtQKRZSFibFCHbMELYKDr3tUdUfCDqVjipCzHmLZ+xMisfn yX9aTVI3FUIs8UiqM5xlxqfuCnDrKBJjQs3uvmd6cyhPRmnsjase48RoO84Ckjbp/HVu0+1+ 6vgiPjbe4xk7Ehkw1mfSxb79ABEBAAHCwF8EGAEIAAkFAlXtplYCGwwACgkQCC3Esa/37p7u XwgAjpFzUj+GMmo8ZeYwHH6YfNZQV+hfesr7tqlZn5DhQXJgT2NF6qh5Vn8TcFPR4JZiVIkF o0je7c8FJe34Aqex/H9R8LxvhENX/YOtq5+PqZj59y9G9+0FFZ1CyguTDC845zuJnnR5A0lw FARZaL8T7e6UGphtiT0NdR7EXnJ/alvtsnsNudtvFnKtigYvtw2wthW6CLvwrFjsuiXPjVUX 825zQUnBHnrED6vG67UG4z5cQ4uY/LcSNsqBsoj6/wsT0pnqdibhCWmgFimOsSRgaF7qsVtg TWyQDTjH643+qYbJJdH91LASRLrenRCgpCXgzNWAMX6PJlqLrNX1Ye4CQw== Organization: Ultimate Linux Solutions (Pty) Ltd In-Reply-To: <87y1cxmovv.fsf@gentoo.org> X-Spam-report: Relay access (uriel.iewc.co.za). X-Archives-Salt: 5d839bd1-51f8-409e-90ec-fa2e74a00238 X-Archives-Hash: af86e608321837ca3814ebd554feca52 This is a multi-part message in MIME format. --------------OXdyTE0cJKh7EzgpdvEPGGSs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Sam, On 2024/01/10 13:02, Sam James wrote: > Jaco Kroon writes: > >> How critical is it that they do? >> Even for the bump PR they do not, they fail with the below, and >> frankly my knowledge of ruby is outright scary.  The below to me >> indicates that the tests are designed specifically to run from a git >> checkout, there are two possible "fixes": >> >> 1.  patch the code to not require this. >> 2.  disable tests. Looking at the code it's simply looking for the .git folder, so mkdir ..../.git may circumvent this problem if we can solve the below. >> >>>>> Test phase: app-admin/fluentd-1.16.3 >>  * Running test phase for ruby31 >> [...] >> [...] >> :85:in >> `require': cannot load such file -- rr (LoadError) > Try adding a test dep on dev-ruby/rr. Tests are busy running now.  Seem to be slow.  Updated ebuild pushed to the PR.  Will advise test outcome on the PR. Someone will probably need/want to look at this circular dependency at some point.  * Error: circular dependencies: (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) depends on  (dev-ruby/rspec-3.12.0:3/3::gentoo, ebuild scheduled for merge) (buildtime)   (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) (buildtime) [test] for each depends on the other, so setting a global FEATURES=test breaks things.  I don't think this is a critical issue. > > Anyway, if it works for you in production, and you're willing to > (reluctantly) adopt it, then we can work on the tests later. "no choice", so please do proceed to merge the PR. Kind regards, Jaco > --------------OXdyTE0cJKh7EzgpdvEPGGSs Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Sam,

On 2024/01/10 13:02, Sam James wrote:
Jaco Kroon <jaco@uls.co.za> writes:
How critical is it that they do? 
Even for the bump PR they do not, they fail with the below, and
frankly my knowledge of ruby is outright scary.  The below to me
indicates that the tests are designed specifically to run from a git
checkout, there are two possible "fixes":

1.  patch the code to not require this.
2.  disable tests.

Looking at the code it's simply looking for the .git folder, so mkdir ..../.git may circumvent this problem if we can solve the below.



Test phase: app-admin/fluentd-1.16.3

 * Running test phase for ruby31
[...]
[...]
<internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in
`require': cannot load such file -- rr (LoadError)

Try adding a test dep on dev-ruby/rr.

Tests are busy running now.  Seem to be slow.  Updated ebuild pushed to the PR.  Will advise test outcome on the PR.

Someone will probably need/want to look at this circular dependency at some point.

 * Error: circular dependencies:

(dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) depends on
 (dev-ruby/rspec-3.12.0:3/3::gentoo, ebuild scheduled for merge) (buildtime)
  (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) (buildtime)

[test] for each depends on the other, so setting a global FEATURES=test breaks things.  I don't think this is a critical issue.


Anyway, if it works for you in production, and you're willing to
(reluctantly) adopt it, then we can work on the tests later.

"no choice", so please do proceed to merge the PR.

Kind regards,
Jaco
--------------OXdyTE0cJKh7EzgpdvEPGGSs--