From: Jaco Kroon <jaco@uls.co.za>
To: gentoo-dev@lists.gentoo.org, Sam James <sam@gentoo.org>
Subject: Re: [gentoo-dev] Last rites: app-admin/fluentd
Date: Wed, 10 Jan 2024 16:20:56 +0200 [thread overview]
Message-ID: <d2eee9ad-25a7-423d-ae3f-f68f4108dab1@uls.co.za> (raw)
In-Reply-To: <87y1cxmovv.fsf@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]
Hi Sam,
On 2024/01/10 13:02, Sam James wrote:
> Jaco Kroon<jaco@uls.co.za> writes:
>
>> How critical is it that they do?
>> Even for the bump PR they do not, they fail with the below, and
>> frankly my knowledge of ruby is outright scary. The below to me
>> indicates that the tests are designed specifically to run from a git
>> checkout, there are two possible "fixes":
>>
>> 1. patch the code to not require this.
>> 2. disable tests.
Looking at the code it's simply looking for the .git folder, so mkdir
..../.git may circumvent this problem if we can solve the below.
>>
>>>>> Test phase: app-admin/fluentd-1.16.3
>> * Running test phase for ruby31
>> [...]
>> [...]
>> <internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in
>> `require': cannot load such file -- rr (LoadError)
> Try adding a test dep on dev-ruby/rr.
Tests are busy running now. Seem to be slow. Updated ebuild pushed to
the PR. Will advise test outcome on the PR.
Someone will probably need/want to look at this circular dependency at
some point.
* Error: circular dependencies:
(dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for
merge) depends on
(dev-ruby/rspec-3.12.0:3/3::gentoo, ebuild scheduled for merge)
(buildtime)
(dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for
merge) (buildtime)
[test] for each depends on the other, so setting a global FEATURES=test
breaks things. I don't think this is a critical issue.
>
> Anyway, if it works for you in production, and you're willing to
> (reluctantly) adopt it, then we can work on the tests later.
"no choice", so please do proceed to merge the PR.
Kind regards,
Jaco
>
[-- Attachment #2: Type: text/html, Size: 3198 bytes --]
next prev parent reply other threads:[~2024-01-10 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-31 10:34 [gentoo-dev] Last rites: app-admin/fluentd Michał Górny
2024-01-09 10:54 ` Jaco Kroon
2024-01-09 11:42 ` Michał Górny
2024-01-09 16:19 ` Jaco Kroon
2024-01-10 11:02 ` Sam James
2024-01-10 14:20 ` Jaco Kroon [this message]
2024-01-13 9:38 ` Hans de Graaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2eee9ad-25a7-423d-ae3f-f68f4108dab1@uls.co.za \
--to=jaco@uls.co.za \
--cc=gentoo-dev@lists.gentoo.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox