From: Yiyang Wu <xgreenlandforwyy@gmail.com>
To: gentoo-dev@lists.gentoo.org
Cc: Benda Xu <heroxbd@gentoo.org>, Ulrich Mueller <ulm@gentoo.org>
Subject: [gentoo-dev] [PATCH v4 0/2] *** rocm.eclass: new eclass ***
Date: Sun, 28 Aug 2022 13:25:55 +0800 [thread overview]
Message-ID: <cover.1661663431.git.xgreenlandforwyy@gmail.com> (raw)
The v4 patches fixes a bug about determining whether ${gpu_target} is in
${OFFICIAL_AMDGPU_TARGETS[*]}. Nothing else has changed, and the eclass
works as expected in my experiment ebuilds on sci-libs/roc*.
Yiyang Wu (2):
rocm.eclass: new eclass
profiles/desc: add amdgpu_targets.desc for USE_EXPAND
eclass/rocm.eclass | 278 ++++++++++++++++++++++++++++++
profiles/base/make.defaults | 2 +-
profiles/desc/amdgpu_targets.desc | 15 ++
3 files changed, 294 insertions(+), 1 deletion(-)
create mode 100644 eclass/rocm.eclass
create mode 100644 profiles/desc/amdgpu_targets.desc
Interdiff against v3:
diff --git a/eclass/rocm.eclass b/eclass/rocm.eclass
index 4b220db0aa81..225329df4876 100644
--- a/eclass/rocm.eclass
+++ b/eclass/rocm.eclass
@@ -159,7 +159,7 @@ _rocm_set_globals() {
ROCM_REQUIRED_USE+=" || ("
for gpu_target in "${ALL_AMDGPU_TARGETS[@]}"; do
- if has ${gpu_target} "${OFFICIAL_AMDGPU_TARGETS[*]}"; then
+ if has "${gpu_target}" ${OFFICIAL_AMDGPU_TARGETS[*]}; then
IUSE+=" ${gpu_target/#/+amdgpu_targets_}"
else
IUSE+=" ${gpu_target/#/amdgpu_targets_}"
--
2.34.1
next reply other threads:[~2022-08-28 5:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 5:25 Yiyang Wu [this message]
2022-08-28 5:25 ` [gentoo-dev] [PATCH v4 1/2] rocm.eclass: new eclass Yiyang Wu
2022-08-28 5:25 ` [gentoo-dev] [PATCH v4 2/2] profiles/desc: add amdgpu_targets.desc for USE_EXPAND Yiyang Wu
2022-08-28 6:36 ` [gentoo-dev] Re: [PATCH v4 0/2] *** rocm.eclass: new eclass *** Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1661663431.git.xgreenlandforwyy@gmail.com \
--to=xgreenlandforwyy@gmail.com \
--cc=gentoo-dev@lists.gentoo.org \
--cc=heroxbd@gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox