From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 83EFC138334 for ; Thu, 5 Sep 2019 04:03:19 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4A336E07FE; Thu, 5 Sep 2019 04:03:03 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CACBAE07F6 for ; Thu, 5 Sep 2019 04:02:58 +0000 (UTC) Received: from pomiot (c134-66.icpnet.pl [85.221.134.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id CD61934AC53; Thu, 5 Sep 2019 04:02:56 +0000 (UTC) Message-ID: Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 05 Sep 2019 06:02:52 +0200 In-Reply-To: <1860939b-1751-061d-c593-59deb20f05e7@gentoo.org> References: <1567619929.63486fef43c2e0dee3b4128db18fd1a6b4bf9381.tupone@gentoo> <6221fceb9ac4f3451a3a43e39141102f489a830d.camel@gentoo.org> <1860939b-1751-061d-c593-59deb20f05e7@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-+N9tMUZBA/mTcQFlmP0q" User-Agent: Evolution 3.30.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: bf9e17cb-96a3-489c-9922-739dcee04b89 X-Archives-Hash: f12c678fa68d17aa78f60438978d9af7 --=-+N9tMUZBA/mTcQFlmP0q Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-09-05 at 01:26 +0200, Thomas Deutschmann wrote: > Hi, >=20 > On 2019-09-04 20:59, Micha=C5=82 G=C3=B3rny wrote: > > Devmanual is pretty clear on the fact that *all* new eclasses require m= l > > ^^^^^^^^^^^^^^^^^^^^^^^ > > review *before* committing: >=20 > I am also working on a new eclass so I looked up details regarding > what's needed to add a new eclass recently. >=20 > I must say that I disagree that it's *pretty* clear. >=20 > > Adding and Updating Eclasses > >=20 > > Before committing a new eclass to the tree, it should be emailed > > ^^^^^^ > > to the gentoo-dev mailing list with a justification and a > > proposed implementation. Do not skip this step =E2=80=94 sometimes a > > better implementation or an alternative which does not require a > > new eclass will be suggested. > >=20 > > Before updating [...] > >=20 > > The exceptions to this rule are per-package eclasses. For > > ^^^^^^^^^^^^^^^^^^^^ > > example, the apache-2 eclass is only used by the www-servers/apache > > package, and thus does not typically require changes to be emailed > > for review. >=20 > In my case I am working on a new mysql eclass to outsource pkg_config > function which is shared at least between dev-db/mysql and > dev-db/percona-server (and maybe dev-db/mariadb). >=20 > For this new eclass I would say it's a "per-package" eclass and would > probably have skipped mailing list review, too. Everyone can skip as many paragraphs as they want, and then apply what's said later to something said way earlier. >=20 > If you want to make it clear, change "should" to "must" and maybe > clarify per-package exception and limit to update case if you believe > that really *all* *new* eclasses must be send to mailing list. Submit a part. This is a community effort. Nitpicking and complaining doesn't make things better. Fixing them does. >=20 >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-+N9tMUZBA/mTcQFlmP0q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl1wiOxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA4o/wgAgVNuO2zC91jAHndOzt51yZwxqgr/MeQ1R4+1dEHgksElUqBDhzexlR2W TFFwCMQbcF9yzw6CBlTTBy5V/Owor36DX/DCMx21cCXy4hKJepRhYiju81r1fmJz Oky6JNIjNQ+pgLmlMlkdP8chHTxU0vU2L5bTPYdItOFivI9Kdie33eQgQV6hXvjz AKw+o3axWXjjlQS9o4n6zDTT1Dd5niROmXhrf7FfZUNzPTXoIW98/31whQB0fvng x1MRT7XobkKR4Eo6IwC+eKpIgNubf2jEtFF0qnFJgsQAi/IkIXD/qKj1//4IlKDs hmzeMkpfLstCe+DK24u1s0sdG5XEcg== =tkq/ -----END PGP SIGNATURE----- --=-+N9tMUZBA/mTcQFlmP0q--