From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-83492-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 44ED3138206
	for <garchives@archives.gentoo.org>; Mon, 15 Jan 2018 18:34:26 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id CB5B2E08F1;
	Mon, 15 Jan 2018 18:34:21 +0000 (UTC)
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 7AA63E08DB
	for <gentoo-dev@lists.gentoo.org>; Mon, 15 Jan 2018 18:34:21 +0000 (UTC)
Received: from [192.168.1.100] (c-98-218-46-55.hsd1.md.comcast.net [98.218.46.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: mjo)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 3245E335C54
	for <gentoo-dev@lists.gentoo.org>; Mon, 15 Jan 2018 18:34:20 +0000 (UTC)
Subject: Re: [gentoo-dev] [PATCH] linux-mod.eclass: IUSE default support for
 MODULES_OPTIONAL_USE
To: gentoo-dev@lists.gentoo.org
References: <robbat2-20180114T234941-135666777Z@orbis-terrarum.net>
From: Michael Orlitzky <mjo@gentoo.org>
Message-ID: <cc57c14d-e4c3-df4d-3ff7-85bef077744d@gentoo.org>
Date: Mon, 15 Jan 2018 13:34:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
In-Reply-To: <robbat2-20180114T234941-135666777Z@orbis-terrarum.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Archives-Salt: ae3555be-edd0-4c29-90e0-19eb8d037d3f
X-Archives-Hash: 7ddf2e699d20c69789712f035e6bb7c3

On 01/14/2018 06:53 PM, Robin H. Johnson wrote:
> +# @ECLASS-VARIABLE: MODULES_OPTIONAL_USE_IUSE_DEFAULT
> +# @DESCRIPTION:
> +# A boolean to control the IUSE default state for the MODULES_OPTIONAL_USE USE
> +# flag. Default value is unset (false). True represented by 1 or 'on', other
> +# values including unset treated as false.
> +
> ...
> +
> +case $MODULES_OPTIONAL_USE_IUSE_DEFAULT in
> +	1) _modules_optional_use_iuse_default='+' ;;
> +	*) _modules_optional_use_iuse_default='' ;;
> +esac

I missed this the first time around, but the case statement needs to
catch "on", too.